Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Roller v0.1.1
Description
According to RUSTSEC-2024-0346 the transitive/indirect dependencies
zerovecandzerovec-derivewere assuming that#[repr(packed)]guarantees field order (rust-lang/rust#125360 (comment)) although that's not guaranteed by the Rust spec and could lead to illegal memory access.The updated version (unicode-org/icu4x#5196) seems to use
#[repr(C, packed)]which does guarantee field order.Although, after updating all the package's transitive dependencies, it seems like both
zerovecandzerovec-derivehave been completely removed from the.lockand therefor not a dependency anymore, even indirect.File changes
Cargo.lock: Updated transitive dependencies,zerovecandzerovec-deriveremoval, package bump to0.1.1Cargo.toml: Package bump to0.1.1