fix(geocoding): use PointGeometry for Feature and RetrieveFeature#10
Merged
Conversation
backevik
force-pushed
the
fix/point-geometry-coordinates
branch
2 times, most recently
from
a6d9d2a to
51481fc
Compare
GeoJSONGeometry.Coordinates was [][]float64 (LineString), but Geocoding v6 returns Point geometry with a flat [lon, lat] coordinate. JSON decode failed with 'cannot unmarshal number into Go struct field GeoJSONGeometry'. Add PointGeometry with []float64 coordinates and use it for Feature and RetrieveFeature. GeoJSONGeometry (LineString) remains unchanged for map matching.
backevik
force-pushed
the
fix/point-geometry-coordinates
branch
from
51481fc to
7280ee5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GeoJSONGeometry.Coordinateswas typed asanybut geocoding Feature and RetrieveFeature embed it and the JSON decoder failed to unmarshal Point coordinates ([lon, lat]) correctly in productioncannot unmarshal number into Go struct field GeoJSONGeometryPointGeometrywithCoordinates []float64and use it forFeature(geocoding) andRetrieveFeature(searchbox);GeoJSONGeometryremains unchanged for map matchingTest plan
TestReverseGeocode_PointGeometrydecodes a real Mapbox Point geometry response body