fix(mapmatching): type GeoJSONGeometry.Coordinates as [][]float64#7
Merged
Conversation
The Map Matching API always returns a LineString geometry when geometries=geojson is set. Using [][]float64 instead of any removes all type assertion boilerplate from callers and makes the axis order ([longitude, latitude]) explicit in the type.
backevik
force-pushed
the
fix/linestring-coordinates-type
branch
from
a7c1bbb to
43318f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GeoJSONGeometry.Coordinateswas typed asany, requiring callers to assert[]interface{}and then[]interface{}for each pair before extractingfloat64valuesgeometries=geojsonis set, so[][]float64is the correct and complete typepair[0]= longitude,pair[1]= latitudeTest plan
TestMapMatch_GeometryDecodedverifying the real JSON decodes into[][]float64with correct values