feat(geocoding): use Permanent tier for reverse geocoding#8
Merged
Conversation
backevik
force-pushed
the
backevik/geocoding-permanent-tier
branch
from
0ef861a to
a77fac5
Compare
Add Permanent bool to ReverseGeocodeRequest and BatchReverseGeocodeRequest. When true, passes permanent=true to the Mapbox API, selecting the Permanent tier which permits storing and caching geocoding results. Defaults to false (Temporary tier) to preserve backward compatibility.
backevik
force-pushed
the
backevik/geocoding-permanent-tier
branch
from
a77fac5 to
0650345
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
Permanent booltoReverseGeocodeRequestandBatchReverseGeocodeRequest.When
true:permanent=trueas a query parameter toGET /search/geocode/v6/reversepermanent: truein each query object in thePOST /search/geocode/v6/batchbodyWithout this flag, Mapbox uses the Temporary tier which does not permit storing results. With
Permanent: true, requests use the Permanent tier which permits storage. Defaults tofalseto preserve backward compatibility.Test plan
permanent=trueappears in the wire request whenPermanent: trueis setpermanentis absent from the wire request whenPermanent: false(default)