Add case insensitivity to email search + test cases

[rosalieper]

Bug: T415017

[outdooracorn]

This looks interesting, and it's not immediately obvious to me why it is needed. Can we add a comment above this line to explain it?

[deer-wmde]

Looking at the table schema, the datatype of the user_email field is tinyblob, so I guess it makes sense (or is maybe even necessary) for the comparison: https://github.com/wbstack/api/blob/main/database/mw/new/mw1.43-wbs2.sql#L1005

edit:

gave it a quick test:

MariaDB root@localhost:mwdb_8127892d75> SELECT user_email FROM mwt_022411e763_user WHERE LOWER(CONVERT(user_email USING utf8mb4)) = LOWER('DENA@DENA.DENA') \G
***************************[ 1. row ]***************************
user_email | Dena@DENA.dena

1 row in set
Time: 0.002s

MariaDB root@localhost:mwdb_8127892d75> SELECT user_email FROM mwt_022411e763_user WHERE LOWER(user_email) = LOWER('DENA@DENA.DENA') \G
0 rows in set
Time: 0.002s

[deer-wmde]

can confirm case-insensitive search works in the current state:

0 12:18 » deer@wmde-102295 ~/wbaas/wbaas-deploy (main *)
 $ k exec -ti deployments/api-queue-default -- php artisan wbs-user:check-email TEST@test.com
FOUND: TEST@test.com in apidb.users
FOUND: TEST@test.com in mwdb_bfb51d26a3.mwt_7693b27217_user
-------------------------------------------------
0 12:18 » deer@wmde-102295 ~/wbaas/wbaas-deploy (main *)
 $ k exec -ti deployments/api-queue-default -- php artisan wbs-user:check-email test@test.com
FOUND: test@test.com in apidb.users
FOUND: test@test.com in mwdb_bfb51d26a3.mwt_7693b27217_user
-------------------------------------------------
0 12:18 » deer@wmde-102295 ~/wbaas/wbaas-deploy (main *)
 $ k exec -ti deployments/api-queue-default -- php artisan wbs-user:check-email test@TEST.com
FOUND: test@TEST.com in apidb.users
FOUND: test@TEST.com in mwdb_bfb51d26a3.mwt_7693b27217_user
-------------------------------------------------

As Ollie pointed out it would be nice to get the search result string in the output and not the input string, but I can see how this is a bit difficult here because it would need to happen in WikiUserEmailChecker.php

[outdooracorn]

As Ollie pointed out it would be nice to get the search result string in the output and not the input string, but I can see how this is a bit difficult here because it would need to happen in WikiUserEmailChecker.php

I suggest we get the case-insensitive stuff merged now, so we can do this GDPR request done before the time runs out, and can think about improvements after. 🙂