Skip to content

Added client docs#47

Merged
dannyjameswilliams merged 3 commits into
mainfrom
docs_build
May 19, 2026
Merged

Added client docs#47
dannyjameswilliams merged 3 commits into
mainfrom
docs_build

Conversation

@dannyjameswilliams

Copy link
Copy Markdown
Contributor

Mirroring the implementation in Weaviate's TS client, this enables the use of Github Pages to create client documentation according to the docstrings and such from the code.

Uses github actions (modifying the release.yaml) to automatically push the docs on a release.

Also adds docstrings to all major functions and explanations, in parity with the PR for the Python client

@orca-security-eu orca-security-eu Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

@dannyjameswilliams
dannyjameswilliams requested a review from a team May 18, 2026 08:39
github-actions Bot pushed a commit that referenced this pull request May 18, 2026
@weaviate weaviate deleted a comment from github-actions Bot May 18, 2026

- name: Deploy preview to gh-pages /preview
uses: peaceiris/actions-gh-pages@v4
with:

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude says because it doesn't have keep_files: true this workflow might clear production docs. May you check this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it needs it here because it uses destination_dir so will only clear files at that directory: https://github.com/peaceiris/actions-gh-pages#%EF%B8%8F-allow-empty-commits-allow_empty_commit

So I need keep_files: false to clear the preview page, but keep_files: true on the root level to stop it wiping the preview

@dannyjameswilliams
dannyjameswilliams merged commit 836ecfe into main May 19, 2026
5 checks passed
@dannyjameswilliams
dannyjameswilliams deleted the docs_build branch May 19, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants