Merged
Conversation
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Secrets | View in Orca |
Separate query-only metadata from the metadata that's always available. Retire Read- / Write- counterparts and use a single record.
cross-tenant references are not supported on the server
Some integration tests failed w/ a BufferUnderflow exception when run against v1.32.16, which we can handle more gracefully by returning null from decodeUuid(). An invalid UUID is a server-side issue and we should not try to decode it in the client.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces Read-/WriteWeaviateObject with a unified WeaviateObject type, effectively reversing #503.
After some discussion it is clear that reference properties are the key difference between the read- / write- objects and that the user needn't be aware of that unless they're working with reference properties.
Inserting data
Metadata fields are now split into those always present (uuid, vectors, timestamps, tenants) and those related to queries (see
QueryMetadata).Querying data
Traversing references
A helper
.asWeaviateObject()allows users to cast references into WeaviateObjects for an easier traversal