ci: run integration tests against Weaviate 1.39.0-rc.0#2099
Open
jfrancoa wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
Bumps the integration-test matrix from 1.36.x to 1.39.0-rc.0 and adds the version to the test-package matrix. There is no plain `1.39.0-rc.0` tag on Docker Hub yet, only commit-suffixed builds, so the newest one is pinned following the existing `WEAVIATE_137` convention. One existing test needed adapting to an intentional server change in 1.39: `asyncEnabled` is no longer stored per class but derived server-side as `factor > 1 && !globallyDisabled`. `test_collection_config_full` uses a replication factor of 1, so the field now reports `False`. The pre-1.39 assertions are kept behind a version check. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
jfrancoa
force-pushed
the
bump-integration-tests-1.39
branch
from
July 22, 2026 12:05
736a7cd to
be6c8dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the integration-test matrix from
$WEAVIATE_136(1.36.12) to a new$WEAVIATE_139(1.39.0-rc.0) and adds the version to thetest-packagematrix.This is split out of #1991 so that the version bump and its fallout can be reviewed on their own, rather than mixed into the alter-schema drop-vector-index feature. #1991 is stacked on top of this branch.
Why now
The drop-vector-index endpoint only exists from 1.39, so its tests cannot run in CI until the matrix moves. Independently, the matrix has been sitting on 1.36.x while
$WEAVIATE_137was already defined, so a range of version-gated tests never actually executed — 56 more tests run at 1.39 than at 1.36.12 (1072 passed vs 1016).Pinned tag
There is no plain
1.39.0-rc.0tag on Docker Hub yet, only commit-suffixed builds, so the newest one is pinned following the existingWEAVIATE_137convention. Worth swapping for the clean tag once the RC is published.Test change
One existing test needed adapting to an intentional server change. From 1.39
asyncEnabledis no longer stored per class but derived server-side asfactor > 1 && !globallyDisabled(adapters/handlers/rest/restcompat/wrappers.go). Three assertion sites use a replication factor of 1 and therefore now expectFalse.Rather than sprinkling version checks, the scattered
is_at_least(1, 26, 0)branches are replaced by one_expected_async_enabled(version, factor)helper that encodes both the old and new server behaviour. The two sites usingfactor=2are unaffected —factor > 1still yieldsTruethere — and are left alone.No coverage is removed: the pre-1.39 expectations remain asserted on older servers.
Verification
The full integration suite was run against 1.36.12 and against 1.39.0-rc.0 on an otherwise identical local stack built from
ci/docker-compose.yml. Both produce identical failure sets (109 entries, all from compose instances not available locally), so the bump introduces no regressions in the ~1000 tests that environment can exercise.Two caveats for reviewers:
.arm64image variants; CI uses the.amd64tags pinned here.🤖 Generated with Claude Code