Jonker/add link text#75
Closed
bryanjonker-illinois wants to merge 2 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds new API endpoints for loading Notes, FAQs, and Events via HTTP, allowing these entities to be created or updated through the API with proper authentication and logging. It also refactors existing controller classes for consistency, improves dependency injection setup, and streamlines variable declarations for readability.
New API Endpoints and Business Logic:
Loadendpoints toNotes,Faqs, andEventscontrollers, enabling creation or update of these entities through the API. These endpoints require an API key, handle draft logic, and log submissions usingLogHelper. (ResourceInformationV2.Function/Notes.cs[1]ResourceInformationV2.Function/Faqs.cs[2]ResourceInformationV2.Function/Events.cs[3]Dependency Injection Improvements:
NoteSetter,FaqSetter,EventSetter,PublicationSetter) in the dependency injection container to support the new endpoints. (ResourceInformationV2.Function/Program.csResourceInformationV2.Function/Program.csR48-R56)Constructor and Field Updates:
Notes,Faqs, andEventsto receive new dependencies (ApiHelper,LogHelper, and corresponding setter classes) via dependency injection. (ResourceInformationV2.Function/Notes.cs[1]ResourceInformationV2.Function/Faqs.cs[2]ResourceInformationV2.Function/Events.cs[3]Code Style and Readability:
NotesandFaqscontrollers to usevarfor consistency and readability. (ResourceInformationV2.Function/Notes.cs[1] [2];ResourceInformationV2.Function/Faqs.cs[3] [4]Minor Logging Consistency:
Peoplecontroller for consistency. (ResourceInformationV2.Function/People.csResourceInformationV2.Function/People.csL92-R92)