Skip to content

updated install file to set gin toolbar on update hook#162

Draft
tjackson2113 wants to merge 5 commits into
4.xfrom
tjackson2113/gin-toolbar
Draft

updated install file to set gin toolbar on update hook#162
tjackson2113 wants to merge 5 commits into
4.xfrom
tjackson2113/gin-toolbar

Conversation

@tjackson2113

Copy link
Copy Markdown
Contributor

Solves part of 1139, set gin toolbar.

When running update, sets gin toolbar to be the sane default we provided previously.
4.x only, 5.x WIP.

@tjackson2113 tjackson2113 requested a review from trubach March 9, 2026 14:04
@trubach trubach added the 4.x Work that needs to be done on the 4.x branch label Mar 9, 2026
@trubach trubach linked an issue Mar 9, 2026 that may be closed by this pull request
@trubach

trubach commented Mar 17, 2026

Copy link
Copy Markdown
Contributor

I'm seeing an issue with the update. After running drush updb, the toolbar is not displaying correctly (see image below)

I think the issue is in the $config->set('classic_toolbar', TRUE); in the helper function. I believe it should be $config->set('classic_toolbar', 'vertical'); instead.

image

@trubach trubach left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tjackson2113 - please see the comments next to the code below.

Comment thread illinois_framework_core.install Outdated
Comment thread illinois_framework_core.install Outdated
@trubach trubach marked this pull request as draft March 27, 2026 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.x Work that needs to be done on the 4.x branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gin: Set toolbar style to vertical

2 participants