chore(deps): upgrade pnpm to 11.3.0#7767
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request upgrades the package manager and engine requirements to pnpm 11.3.0, updates the files glob pattern in packages/create-rsbuild/package.json to target nested template files, and updates the lockfile format. The review feedback highlights two important issues: first, upgrading to pnpm 11 requires adding pnpm.patchedDependencies to the root package.json to prevent build failures due to lockfile format changes; second, the new glob pattern template-*/** may exclude critical dotfiles from the published package, which can be resolved by explicitly including them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades the repo to pnpm 11.3.0 and adjusts the
create-rsbuildpackagefileslist to usetemplate-*/**, avoiding the pnpm 11 publish/pack behavior that otherwise omits the template directories from the published package.Related Links
https://github.com/pnpm/pnpm/releases/tag/v11.3.0