webnn: fixed wrong results for l2Pool2d tests#51783
Merged
chromium-wpt-export-bot merged 1 commit intomasterfrom Apr 7, 2025
Merged
webnn: fixed wrong results for l2Pool2d tests#51783chromium-wpt-export-bot merged 1 commit intomasterfrom
chromium-wpt-export-bot merged 1 commit intomasterfrom
Conversation
This issue was introduced by incorrect implementation of l2Pool2d operator for the case of sliding window having two valid elements in webnn-baseline project. I've submitted a fixing PR[1] there, then got the correct expected data for this CL. [1]: webmachinelearning/webnn-baseline#125 Bug: 383232123 Change-Id: Icdbc0859e642b832330ae309668444a000ff280d Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac14-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6415990 Reviewed-by: Austin Sullivan <asully@chromium.org> Auto-Submit: Feng Dai <feng.dai@intel.com> Reviewed-by: ningxin hu <ningxin.hu@intel.com> Commit-Queue: Feng Dai <feng.dai@intel.com> Cr-Commit-Position: refs/heads/main@{#1443301}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-6415990
branch
from
9e5fc6b to
c1afb93
Compare
wpt-pr-bot
approved these changes
Apr 7, 2025
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue was introduced by incorrect implementation of l2Pool2d
operator for the case of sliding window having two valid elements in
webnn-baseline project. I've submitted a fixing PR1 there, then got
the correct expected data for this CL.
Bug: 383232123
Change-Id: Icdbc0859e642b832330ae309668444a000ff280d
Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac14-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6415990
Reviewed-by: Austin Sullivan <asully@chromium.org>
Auto-Submit: Feng Dai <feng.dai@intel.com>
Reviewed-by: ningxin hu <ningxin.hu@intel.com>
Commit-Queue: Feng Dai <feng.dai@intel.com>
Cr-Commit-Position: refs/heads/main@{#1443301}