Payment Handler: Add test for OperationError propagation#59002
Merged
stephenmcgruer merged 7 commits intomasterfrom Apr 23, 2026
Merged
Payment Handler: Add test for OperationError propagation#59002stephenmcgruer merged 7 commits intomasterfrom
stephenmcgruer merged 7 commits intomasterfrom
Conversation
This change adds a new manual test to verify that if a web-based payment handler rejects the promise passed to respondWith with an OperationError, the original PaymentRequest.show() call also rejects with an OperationError. For other error types (like SyntaxError), show() should still reject with an AbortError. Spec: w3c/web-based-payment-handler#428
Merged
6 tasks
Contributor
Author
|
Having some trouble verifying that the test works atm because of WPT issues, but PTAL. |
Contributor
Author
|
Ok, confirmed these manual tests pass with the Chrome implementation changes for w3c/web-based-payment-handler#429 patched in. Otherwise the first test fails and the second passes, as would be expected. |
ianbjacobs
approved these changes
Apr 6, 2026
stephenmcgruer
deleted the
smcgruer/web-based-payment-handler-operation-error
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a new manual test to verify that if a web-based payment handler rejects the promise passed to respondWith with an OperationError, the original PaymentRequest.show() call also rejects with an OperationError.
For other error types (like SyntaxError), show() should still reject with an AbortError.
Spec: w3c/web-based-payment-handler#428