Allow relative scrolls in unrelated-gesture-scroll-during-snap.html#60235
Open
denvercoder21 wants to merge 1 commit into
Conversation
At the moment, unrelated-gesture-scroll-during-snap.html expects to snap back to 0, which can only be the case for absolute scrolls, because they don't have an intended direction. Relative scrolls however, must have an intended direction and therefore snap forward in that intended direction. See issue: web-platform-tests/interop#1288
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment,
unrelated-gesture-scroll-during-snap.htmlexpects to snap back to 0, which can only be the case for absolute scrolls, because they don't have an intended direction.Relative scrolls however, must have an intended direction and therefore snap forward in that intended direction.
WebDriver scroll actions can use wheel events, which are relative scrolls. Or they could use pan gestures, which will soon will be treated as relative scrolls, too: csswg-drafts #12840.
Withouth the suggested change, the test currently:
Fails, because Firefox treats both wheel events and pan gestures as relative scrolls with an intended direction already.
Passes, because Chrome does not yet add an intended direction to pixel-precise relative scrolls. (see InputHandler::CreateSnapStrategy)
Not tested.
See issue:
web-platform-tests/interop#1288