[WebAudio] Fix flaky WPT sinkId tests on headless shell bots#60252
Merged
Conversation
This CL refactors the AudioContext sinkId WPT tests to eliminate timing races and fragile timeouts that cause CQ failures: 1. Constructor tests are converted from legacy async_test to modern promise_test, completely removing fragile 100ms step timeouts. 2. State change tests are restructured to register all event handlers before initiating resume() transitions, eliminating a timing race. 3. setSinkId tests are isolated per test file, and the timing race in close rejections is fixed by utilizing a valid silent sink option instead of an invalid device ID. 4. Detached iframe tests are updated to manually catch cross-realm exceptions, ensuring compatibility with WPT harness validations. Bug: 514359173, 514384316, 514528222 Change-Id: I4c42b66e43207c9147ecd0c4353241f81281af21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7883424 Reviewed-by: Michael Wilson <mjwilson@chromium.org> Commit-Queue: Mahesh Kannan <kmaheshb@google.com> Cr-Commit-Position: refs/heads/main@{#1638538}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7883424
branch
from
d0deeb7 to
d8603ab
Compare
wpt-pr-bot
approved these changes
May 29, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This CL refactors the AudioContext sinkId WPT tests to eliminate
timing races and fragile timeouts that cause CQ failures:
promise_test, completely removing fragile 100ms step timeouts.
handlers before initiating resume() transitions, eliminating
a timing race.
in close rejections is fixed by utilizing a valid silent sink
option instead of an invalid device ID.
exceptions, ensuring compatibility with WPT harness validations.
Bug: 514359173, 514384316, 514528222
Change-Id: I4c42b66e43207c9147ecd0c4353241f81281af21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7883424
Reviewed-by: Michael Wilson <mjwilson@chromium.org>
Commit-Queue: Mahesh Kannan <kmaheshb@google.com>
Cr-Commit-Position: refs/heads/main@{#1638538}