Update CSS drop-shadow to avoid leaking currentcolor#60265
Merged
Conversation
We need to use DependsOnCurrentColor() rather than IsCurrentColor() to catch cases where a color function may reference 'currentcolor'. Bug: 517234388 Change-Id: Ia17bd4e9d532222570996d16f9cb04f11ce2f2b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7882116 Reviewed-by: Fredrik Söderquist <fs@opera.com> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1638520}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7882116
branch
from
8e58488 to
22a40e3
Compare
wpt-pr-bot
approved these changes
May 29, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to use DependsOnCurrentColor() rather than IsCurrentColor() to
catch cases where a color function may reference 'currentcolor'.
Bug: 517234388
Change-Id: Ia17bd4e9d532222570996d16f9cb04f11ce2f2b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7882116
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1638520}