[Gecko Bug 2042572] Teach nsCSSFrameConstructor::GetAbsoluteContainingBlock() the concept of IB-split.#60270
Merged
Merged
Conversation
… of IB-split. The bug happens when we reconstruct the abspos element inside the IB-split block-wrapper where the inline element is an absolute containing block. In `GetAbsoluteContainingBlock()`, when `absPosCBCandidate` is the `MozBlockInsideInlineWrapper`, redirect the candidate to the first IB-split sibling that is the absolute containing block. Otherwise, the function will continue going up the parent chain until it finds `nsCanvasFrame` (the initial containing block). Differential Revision: https://phabricator.services.mozilla.com/D303124 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2042572 gecko-commit: 8d22130515adcd36a9faa02509c5674e42c80354 gecko-commit-git: 071f7c450fe92d36be470f88ad486648e218c4d1 gecko-reviewers: dholbert, layout-reviewers
wpt-pr-bot
approved these changes
May 29, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Firefox project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug happens when we reconstruct the abspos element inside the IB-split
block-wrapper where the inline element is an absolute containing block.
In
GetAbsoluteContainingBlock(), whenabsPosCBCandidateis theMozBlockInsideInlineWrapper, redirect the candidate to the first IB-splitsibling that is the absolute containing block. Otherwise, the function will
continue going up the parent chain until it finds
nsCanvasFrame(the initialcontaining block).
Differential Revision: https://phabricator.services.mozilla.com/D303124
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2042572
gecko-commit: 8d22130515adcd36a9faa02509c5674e42c80354
gecko-commit-git: 071f7c450fe92d36be470f88ad486648e218c4d1
gecko-reviewers: dholbert, layout-reviewers