[Gecko Bug 1886762] Part 2 - Make GetAnchorPosRect() and helper aware of inline containing block and IB-split.#60272
Merged
Merged
Conversation
…g block and IB-split. `IsProperAncestorFrameConsideringContinuations()` gets the ability to traverse IB-split. This doesn't change behavior for existing callers because they are all within `MOZ_ASSERT`. Delete `TraverseUpToContainerChild()` since it is not aware of continuations nor IB-split, and we don't need a returned child frame pointer. Fixing it properly makes its functionally equivalent to `IsProperAncestorFrameConsideringContinuations()`. Differential Revision: https://phabricator.services.mozilla.com/D303080 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1886762 gecko-commit: d93263889e6ca07c69c8f5ee085645610983be17 gecko-commit-git: 1d86c70a438711e31bf9535798f2c26e713a9d99 gecko-reviewers: layout-reviewers, dshin
wpt-pr-bot
approved these changes
May 29, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Firefox project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IsProperAncestorFrameConsideringContinuations()gets the ability to traverseIB-split. This doesn't change behavior for existing callers because they are all
within
MOZ_ASSERT.Delete
TraverseUpToContainerChild()since it is not aware of continuations norIB-split, and we don't need a returned child frame pointer. Fixing it properly
makes its functionally equivalent to
IsProperAncestorFrameConsideringContinuations().Differential Revision: https://phabricator.services.mozilla.com/D303080
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1886762
gecko-commit: d93263889e6ca07c69c8f5ee085645610983be17
gecko-commit-git: 1d86c70a438711e31bf9535798f2c26e713a9d99
gecko-reviewers: layout-reviewers, dshin