[Gecko Bug 1463402] Revert "Bug 1463402: Flip pref for dom.media-pip.enabled " for causing Picture-in-Picture related wpt failures.#60273
Merged
Conversation
…g Picture-in-Picture related wpt failures. This reverts commit a958b57333eeb9f46373e48037d333e4fc65c3ff. This reverts commit 958e255d90c06c1019c6392b9f92881b3d6bb078. This reverts commit 7df07e6a220adb2f523ba8e8d6f91698eab69e36. This reverts commit 160de9227f38fad0d14f168b9bb9604bbff8ecbd. This reverts commit dbf90cfe0d11cc31c16a173b89b69d9ac1c137ba. This reverts commit c9cd940b88c549aae9016b25839fd4d8a4679f80. This reverts commit 3842c6faa40a0de8a09348413fe78c0d5798cf0a. This reverts commit 2e3ab76d53d8ea23002db30e5203ff024049fa41. This reverts commit 2beb01dcef109fb5804fa85f3fc5b4a97ca84ce1. gecko-commit: 7071fdeb0c259a405a96eecc443126fd7389f00c gecko-commit-git: 4f93cc444071b72e0b90b086ce1f60ba696d5e24 gecko-reviewers: dom-core, smaug, webidl
wpt-pr-bot
approved these changes
May 29, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Firefox project.
Added test to verify that iframe attribute is honored. Differential Revision: https://phabricator.services.mozilla.com/D298573 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1463402 gecko-commit: 306d09e4126e15429af290cb0495e2bf3cae047e gecko-commit-git: cc1092a99eb49c6b674924fbdc5627c323d2eab0 gecko-reviewers: dom-core, smaug
Tests the following scenario Steps: - video1 enters pip - video2 requests pip Observe that video1 has its event handlers fire before video2 sees its enter event. At the moment, this requires a change to the exit algorithm in spec, because it always queues a task to fire the exit event in step 3, which would mean that it would always come after the enter event for video2. See issue w3c/picture-in-picture#252 Tested on Chrome & Gecko. Both pass. Differential Revision: https://phabricator.services.mozilla.com/D299344 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1463402 gecko-commit: 560c147d61e871e07716b25dc9103e7b87cab895 gecko-commit-git: 804fb88d9b7f46bbe48d9534133d4914f5680bee gecko-reviewers: smaug
Previous Shadow DOM test were nowhere near enough covering. This tests both current state of spec, but also w3c/picture-in-picture#248. Differential Revision: https://phabricator.services.mozilla.com/D299755 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1463402 gecko-commit: 51b69798195c42113a011dc804b1d85b9400353a gecko-commit-git: a7c2f26ff4f6ce69e52289bb5768752db53c0111 gecko-reviewers: smaug
https://w3c.github.io/picture-in-picture/#exit-picture-in-picture-algorithm Explains "As one of the unloading document cleanup steps, run the exit Picture-in-Picture algorithm.". This test verifies that browsers implement this. Differential Revision: https://phabricator.services.mozilla.com/D299972 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1463402 gecko-commit: 5c20d9f55f50fc2dba92d6ceddc330106ee37e4e gecko-commit-git: 3d496341e15282bbd7f5145037fe89af7282c0b8 gecko-reviewers: smaug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit a958b57333eeb9f46373e48037d333e4fc65c3ff.
This reverts commit 958e255d90c06c1019c6392b9f92881b3d6bb078.
This reverts commit 7df07e6a220adb2f523ba8e8d6f91698eab69e36.
This reverts commit 160de9227f38fad0d14f168b9bb9604bbff8ecbd.
This reverts commit dbf90cfe0d11cc31c16a173b89b69d9ac1c137ba.
This reverts commit c9cd940b88c549aae9016b25839fd4d8a4679f80.
This reverts commit 3842c6faa40a0de8a09348413fe78c0d5798cf0a.
This reverts commit 2e3ab76d53d8ea23002db30e5203ff024049fa41.
This reverts commit 2beb01dcef109fb5804fa85f3fc5b4a97ca84ce1.
gecko-commit: 7071fdeb0c259a405a96eecc443126fd7389f00c
gecko-commit-git: 4f93cc444071b72e0b90b086ce1f60ba696d5e24
gecko-reviewers: dom-core, smaug, webidl