[CE] Split set-constraints-combinations test into multiple files.#60278
Open
chromium-wpt-export-bot wants to merge 1 commit into
Open
[CE] Split set-constraints-combinations test into multiple files.#60278chromium-wpt-export-bot wants to merge 1 commit into
chromium-wpt-export-bot wants to merge 1 commit into
Conversation
The original test file is split into four new files, each focusing on a specific `type` attribute value for the `<usermedia>` element: "camera", "microphone", "camera microphone", and when the type attribute is null. This refactoring improves test organization and reduces the likelihood of timeouts. Change-Id: I3e0ddf178720a2c31fac6a36cbc686cac2a3de4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7872747 Auto-Submit: Ravjit Uppal <ravjit@chromium.org> Commit-Queue: Ravjit Uppal <ravjit@chromium.org> Reviewed-by: Thomas Nguyen <tungnh@chromium.org> Commit-Queue: Thomas Nguyen <tungnh@chromium.org> Cr-Commit-Position: refs/heads/main@{#1638455}
wpt-pr-bot
approved these changes
May 29, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original test file is split into four new files, each focusing on a
specific
typeattribute value for the\<usermedia>element: "camera","microphone", "camera microphone", and when the type attribute is null.
This refactoring improves test organization and reduces the likelihood
of timeouts.
Change-Id: I3e0ddf178720a2c31fac6a36cbc686cac2a3de4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7872747
Auto-Submit: Ravjit Uppal <ravjit@chromium.org>
Commit-Queue: Ravjit Uppal <ravjit@chromium.org>
Reviewed-by: Thomas Nguyen <tungnh@chromium.org>
Commit-Queue: Thomas Nguyen <tungnh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1638455}