Add reminder to commit db in scheduler tasks#430
Open
queengooborg wants to merge 3 commits intoweb2py:masterfrom
Open
Add reminder to commit db in scheduler tasks#430queengooborg wants to merge 3 commits intoweb2py:masterfrom
queengooborg wants to merge 3 commits intoweb2py:masterfrom
Conversation
Add "Supprimer le modèle "menu.py" in the chapter 3, create an images…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a reminder to commit any database modifications in scheduler tasks. This issue threw me for a loop in my own code, as I hadn't realized that the scheduler does not auto-commit db modifications.
Notice: it may be preferable to have the scheduler auto-commit instead, just like regular web2py functions. This is a change that should not break backwards compatibility.