Skip to content

Bug fix: incorrect combine shipping dimensions features. #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shevsky wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Bug fix: incorrect combine shipping dimensions features. #313

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dde6cb3
Bug fix: incorrect combine shipping dimensions features.
Shevsky Nov 13, 2020
1e309c7
Bug fix: incorrect combine shipping dimensions features.
Shevsky Nov 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/classes/shopShipping.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,10 +264,12 @@ public static function extendItems(&$items, $units = array())

if ($dimensions = self::getShopSettings('shipping_dimensions')) {
$dimensions = preg_split('@\D+@', $dimensions);
$features = $feature_model->getByField((count($dimensions) == 1) ? 'parent_id' : 'id', $dimensions, true);
$features = $feature_model->getByField((count($dimensions) == 1) ? 'parent_id' : 'id', $dimensions, 'id');
Copy link
Author

@Shevsky Shevsky Nov 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Нужно сохранить в ключах массива id характеристики, чтобы в цикле ниже найти информацию о характеристике по ее id.


if (count($features) == 3) {
$map += array_combine($dimension_fields, array_values($features));
foreach($dimension_fields as $dimension_field_key => $dimension_field) {
$map[$dimension_field] = $features[$dimensions[$dimension_field_key]];
}
Copy link
Author

@Shevsky Shevsky Nov 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Для понимания что было раньше и как сейчас будет работать.

$dimensions = [ 94, 92, 93 ]
$dimension_fields = [ 'height', 'width', 'length' ]

До исправления:

$map = [ 'height' => [ 'id' => 92, ... ], 'width' => [ 'id' => 93, ... ], 'length' => [ 'id' => 94, ... ] ]

После:

$map = [ 'height' => [ 'id' => 94, ... ], 'width' => [ 'id' => 92, ... ], 'length' => [ 'id' => 93, ... ] ]

if (isset($units['dimensions'])) {
foreach ($dimension_fields as $field) {
$units[$field] = $units['dimensions'];
Expand Down