Kotlin/infinitescroll views#871
Open
cliebhardt wants to merge 3 commits into
Open
Conversation
- InfiniteScrollCustomLoadingKotlinView - InfiniteScrollKotlinView - InfiniteSrollLoadingKotlinView - Item
cliebhardt
added
the
status: waiting-for-review
cliebhardt
requested review from
EHandtkeBasis,
MatthewHawkins,
bbrennanbasis,
gosteenBASIS,
hyyan and
laurenic0l
as code owners
EHandtkeBasis
requested changes
Mar 27, 2026
EHandtkeBasis
added
status: waiting-for-author
cliebhardt
added
status: on hold
EHandtkeBasis
requested changes
Apr 27, 2026
| classNames + "is-canvas" | ||
| } | ||
| div { | ||
| addClassName("custom-loading") |
Member
There was a problem hiding this comment.
addClassName("custom-loading") — Java-style API when DSL extension is available. Use:
classNames += "custom-loading"| maxWidth = 600.px | ||
| classNames + "is-canvas" | ||
| } | ||
| setIcon(TablerIcon.create("cloud-download")) |
Member
There was a problem hiding this comment.
setIcon(TablerIcon.create("cloud-download")) — uses Java-style factory and setter. Check the InfiniteScroll DSL builder for an icon property or slot and use idiomatic Kotlin instead.
|
|
||
| class Item: Composite<Div>() { | ||
| private val self = boundComponent | ||
| private val random = Random.Default |
Member
There was a problem hiding this comment.
private val random = Random.Default is declared but never used — names.random() uses the stdlib extension, not this field. Remove the dead field.
| div { | ||
| classNames + "item-excerpt" | ||
| text = ("Lorem ipsum dolor sit amet, consectetur adipiscing elit. " | ||
| + "Sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.") |
Member
There was a problem hiding this comment.
String concatenation with +. Use a single string literal:
text = "Lorem ipsum dolor sit amet, consectetur adipiscing elit. Sed do eiusmod tempor incididunt ut labore et dolore magna aliqua."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.