Skip to content

adjusted expand button#947

Open
EHandtkeBasis wants to merge 1 commit into
mainfrom
expand-button-change
Open

adjusted expand button#947
EHandtkeBasis wants to merge 1 commit into
mainfrom
expand-button-change

Conversation

@EHandtkeBasis
Copy link
Copy Markdown
Member

closes #810

Copy link
Copy Markdown
Member

@bbrennanbasis bbrennanbasis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EHandtkeBasis

Since the original issue was with the white space when the button was outside the table, might I suggest an alternative solution and treat the table as if it was an expandable picture? VS Code documentation does this by giving the image a border when hovered and changing the mouse icon, https://code.visualstudio.com/docs/editing/codebasics

Otherwise, the following would need to be addressed:

First, accessibility. The new button is only focusable when the table is clicked, however, for someone relying on tabbing through an article, they'll never have the chance to expand the table. The current expand button is accessible by tabbing through.

Second, when hovered over, the background of the button is transparent, so for smaller tables the text behind is still visible, like for the AppNav Reflected Attributes.

Image

Third, if the table is in focus, the icon covers the text, but doesn't have a background.

Image

Fourth, when the border of the icon button is visible, the icon isn't centered.

Image

Finally, when a user does click the expand button, the expand Icon doesn't leave until the user interacts with the original table again.

Recording.2026-04-28.093728.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: waiting-for-review The PR is ready. Waiting for team members to review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change expand button on tables to not show above

3 participants