adjusted expand button#947
Conversation
There was a problem hiding this comment.
Since the original issue was with the white space when the button was outside the table, might I suggest an alternative solution and treat the table as if it was an expandable picture? VS Code documentation does this by giving the image a border when hovered and changing the mouse icon, https://code.visualstudio.com/docs/editing/codebasics
Otherwise, the following would need to be addressed:
First, accessibility. The new button is only focusable when the table is clicked, however, for someone relying on tabbing through an article, they'll never have the chance to expand the table. The current expand button is accessible by tabbing through.
Second, when hovered over, the background of the button is transparent, so for smaller tables the text behind is still visible, like for the AppNav Reflected Attributes.
Third, if the table is in focus, the icon covers the text, but doesn't have a background.
Fourth, when the border of the icon button is visible, the icon isn't centered.
Finally, when a user does click the expand button, the expand Icon doesn't leave until the user interacts with the original table again.
closes #810