Added common features component.#948
Conversation
EHandtkeBasis
requested review from
MatthewHawkins,
bbrennanbasis,
gosteenBASIS,
hyyan and
laurenic0l
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| - **Accessibility**: Utilize the `NumberField` component with accessibility in mind, adhering to accessibility standards such as proper labeling, keyboard navigation support, and compatibility with assistive technologies. Ensure that users with disabilities can interact with the `NumberField` effectively. | ||
|
|
||
| - **Utilize Increment/Decrement Buttons**: If appropriate for your app, consider utilizing increment and decrement buttons with the `NumberField`. This allows users to adjust the numeric value by a specific increment or decrement with a single click. No newline at end of file | ||
| - **Utilize Increment/Decrement Buttons**: If appropriate for your app, consider utilizing increment and decrement buttons with the `NumberField`. This allows users to adjust the numeric value by a specific increment or decrement with a single click. |
There was a problem hiding this comment.
[webforJ.Simplify] Consider 'use' instead of 'Utilize'.
| - **Accessibility**: Utilize the `NumberField` component with accessibility in mind, adhering to accessibility standards such as proper labeling, keyboard navigation support, and compatibility with assistive technologies. Ensure that users with disabilities can interact with the `NumberField` effectively. | ||
|
|
||
| - **Utilize Increment/Decrement Buttons**: If appropriate for your app, consider utilizing increment and decrement buttons with the `NumberField`. This allows users to adjust the numeric value by a specific increment or decrement with a single click. No newline at end of file | ||
| - **Utilize Increment/Decrement Buttons**: If appropriate for your app, consider utilizing increment and decrement buttons with the `NumberField`. This allows users to adjust the numeric value by a specific increment or decrement with a single click. |
There was a problem hiding this comment.
[webforJ.Simplify] Consider 'using' instead of 'utilizing'.
| - **Spell Checking and Auto-Complete**: When applicable, consider utilizing spellchecking with `setSpellCheck()` and/or using autocomplete in a `TextField`. These features can help users input information faster and reduce errors by providing suggested values based on previous inputs or predefined options. | ||
|
|
||
| - **Accessibility**: Utilize the `TextField` component with accessibility in mind, adhering to accessibility standards such as proper labeling, keyboard navigation support, and compatibility with assistive technologies. Ensure that users with disabilities can interact with the `TextField` effectively. No newline at end of file | ||
| - **Accessibility**: Utilize the `TextField` component with accessibility in mind, adhering to accessibility standards such as proper labeling, keyboard navigation support, and compatibility with assistive technologies. Ensure that users with disabilities can interact with the `TextField` effectively. |
There was a problem hiding this comment.
[webforJ.Simplify] Consider 'use' instead of 'Utilize'.
| - **Spell Checking and Auto-Complete**: When applicable, consider utilizing spellchecking with `setSpellCheck()` and/or using autocomplete in a `TextField`. These features can help users input information faster and reduce errors by providing suggested values based on previous inputs or predefined options. | ||
|
|
||
| - **Accessibility**: Utilize the `TextField` component with accessibility in mind, adhering to accessibility standards such as proper labeling, keyboard navigation support, and compatibility with assistive technologies. Ensure that users with disabilities can interact with the `TextField` effectively. No newline at end of file | ||
| - **Accessibility**: Utilize the `TextField` component with accessibility in mind, adhering to accessibility standards such as proper labeling, keyboard navigation support, and compatibility with assistive technologies. Ensure that users with disabilities can interact with the `TextField` effectively. |
There was a problem hiding this comment.
[webforJ.BeDirect] Avoid using 'Ensure that'. Focus more on explicitly giving details about the feature.
bbrennanbasis
left a comment
bbrennanbasis
left a comment
There was a problem hiding this comment.
- From Issue #64
Ungroup the field components and divide each into its own section.
Does we still want the field components to be on the same TOC level as the rest of the components? What about the masked fields? If this involves moving the file structure, then we'd need to make sure to fix links to these articles.
-
FieldCommonFeaturesis missing from the masked fields, and keep in mind the masked articles already have the styling sections. -
Spellcheck is a shared field feature, but feels unimportant to include for non-text fields like colorfield.
-
The elements in the
AccordionSummaryfor this are<b>tags, but for MCP Server they're<strong>tags, then for Minifier Plugin they're<p>tags. It would be wise to choose one element going forward so we can keep a consistent style across articles. -
Common field features, the header for these sections, doesn't appear in the TOC. TableBuilder includes a function to add the various headers, but since
FieldCommonFeaturesonly has one header that seems like overkill. My suggestion would be moving it outside of the component:## Common field features {#common-field-features) <FieldCommonFeatures /> -
Make the content within
FieldCommonFeaturestranslatable. Use PR #861 and Docusaurus's Translate your React code for reference. -
Is the correct client component being documented in the
ColorFieldstyle section? The renderedFieldCommonFeaturesis showing the details fordwc-color-chooser, but in the DOM theColorFieldcomponent renders as adwc-field:
Regardless, _dwc_control_map.json and FieldCommonFeatures incorrectly label the ColorField component. For both cases, replace Color-Chooser with ColorField.
bbrennanbasis
added
the
status: waiting-for-author
3 participants
closes #64