-
Notifications
You must be signed in to change notification settings - Fork 7
visibility design and discussion #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mighdoll
wants to merge
23
commits into
glob-imports
Choose a base branch
from
visibility
base: glob-imports
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
23c1c0b
Fix #178
stefnotch 2be5aa7
visibility design and discussion
mighdoll 9fc3471
rename org references: wgsl-tooling-wg -> webgpu-tools
mighdoll 75ec680
syntax to @public / @private
mighdoll 21f610d
defer wildcard re-exports to future work
mighdoll eb8bee0
revise based on review feedback
mighdoll af3bf22
add to TOC
mighdoll 3094ab9
move leaked type warning to future possibilities
mighdoll 1ed5b2d
note private contextual keyword status in spec too
mighdoll c79a045
note re-export of modules is reserved in import grammar syntax
mighdoll 1ba40c5
minor editiorial and format
mighdoll 384f1fd
limit wesl.toml root to folders only
mighdoll 08b85bc
clarify package.wesl is optional and root only
mighdoll fb2f1ad
address review comments
stefnotch 6f68abc
Merge pull request #182 from webgpu-tools/fix-wesl-toml
stefnotch 6460f61
merge in updates from wildcard-imports PR #183
mighdoll 5ea9db4
direct import resolution per #193
mighdoll c7af9c7
merge direct-imports (#199) into visibility
mighdoll 7c642e9
Merge pull request #183 from webgpu-tools/glob-imports
mighdoll 5cff896
Merge remote-tracking branch 'refs/remotes/origin/main' into visibility
mighdoll 45cdada
Misc followups after 199 (direct imports) merge
mighdoll 9a381df
address k2d222 comments on #199:
mighdoll 29944a9
misc editiorial
mighdoll File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # macOS | ||
| .DS_Store | ||
|
|
||
| # vi temp files | ||
| *.swp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,11 @@ | ||
| Copyright (c) The wgsl-tooling-wg Contributors. | ||
| Copyright (c) The webgpu-tools Contributors. | ||
|
|
||
| Copyrights in the wgsl-tooling-wg projects are retained by their contributors. | ||
| No copyright assignment is required to contribute to the wgsl-tooling-wg projects. | ||
| Copyrights in the webgpu-tools projects are retained by their contributors. | ||
| No copyright assignment is required to contribute to the webgpu-tools projects. | ||
|
|
||
| Some files include explicit copyright notices and/or license notices. | ||
| For full authorship information, see the version control history. | ||
|
|
||
| Except as otherwise noted, the wgsl-tooling-wg projects are licensed under the | ||
| Except as otherwise noted, the webgpu-tools projects are licensed under the | ||
| Apache License, Version 2.0 <LICENSE-APACHE> or <http://www.apache.org/licenses/LICENSE-2.0> | ||
| or the MIT license <LICENSE-MIT> or <http://opensource.org/licenses/MIT>, at your option. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
later, we can add link error to this list.