More precise grammar for conditional translation#196
Merged
Conversation
stefnotch
requested review from
k2d222 and
mighdoll
and removed request for
mighdoll
k2d222
reviewed
Jun 29, 2026
mighdoll
reviewed
Jul 9, 2026
mighdoll
left a comment
mighdoll
left a comment
Contributor
There was a problem hiding this comment.
looks good, editorial suggestions here.
k2d222
approved these changes
Jul 10, 2026
mighdoll
approved these changes
Jul 12, 2026
This was referenced Jul 12, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conditional translation in the spec and in the implementations does not fully match up. Time to fix this.
Narrower grammar for
@if#191 (comment)
Both in wesl-rs and wgsl-analyzer, the current grammar of
@ifhas been causing implementation woes. To address this with the smallest spec change, I opted to separate "attributes" and "translate-time attributes". Translate-time attributes are@if(...),@elif(...)and@else. They are parsed exactly as such, thus being unambiguous. This change does not reject any existing WESL programs.@elsein the spec#117
Both wesl-js and wesl-rs support
@elifand@else. This adds them to the specCompared to #164 , I did not yet update the name to "condition attributes". I wanted to keep the diff easy to review for this PR.