You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The core issue here is that because the 32-bit GNU toolchains use long long for (std::)int64_t while 64-bit ones use long, int64_t parameters produce different mangled symbol names on 32- and 64-bit targets.
After a lengthy discussion on Discord, we determined the original type is actually GLib's gint64. Superficial research indicates appears that GLib (at least GLib 2.78.6, used by webOS 11) does define gint64 differently across platforms, analogously to how GNU handles int64_t: https://github.com/GNOME/glib/blob/2.78.6/meson.build#L1581-L1610
Therefore, unless we want to introduce GLIb types, we should leave it as int64_t. (While I'm not sure gint64 and int64_t are the same on all platforms, they seem to be for the ones we care about.) Problems might arise when trying to link 64-bit binaries against 32-bit libraries, but we probably shouldn't be doing that.
However, as far as I know webOS 11 userspace is still 32-bit, meaning there are no 64-bit versions of the corresponding (closed-source) LG libraries. Therefore, this question is essentially academic at this point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to AI and compiling under new GCC (64-bit), these should be long long not int64_t.
It fails to compile as is.
Compile error (64-bit).
I've tested this change on kodi 32-bit and 64-bit.