Skip to content

fix(a11y): fixed background contrast issue in Lighthouse #8185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexander-akait merged 3 commits into from
Apr 27, 2026
Merged

fix(a11y): fixed background contrast issue in Lighthouse #8185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8620cbd
fix(a11y): improved contrast
pranjalisr Apr 12, 2026
0f91e00
fix: colors
pranjalisr Apr 17, 2026
439d898
fix(a11y): removed important
pranjalisr Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions src/components/Footer/Footer.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const footerLinkClasses =

const Footer = () => (
<footer className="w-full flex-[0_0_auto] print:hidden">
<Container className="mx-auto max-w-[900px] px-5 pb-[30px] pt-[40px] text-center">
<Container className="mx-auto max-w-[900px] px-5 pb-[30px] pt-[40px] text-center [&_a]:text-[var(--color-link-accessible)] [&_a:hover]:text-[var(--color-link-accessible-hover)] dark:[&_a]:text-[var(--color-link-accessible-dark)] dark:[&_a:hover]:text-white">
<div className="mb-[24px] flex justify-center">
<a href="https://openjsf.org" target="_blank" rel="noopener noreferrer">
<img
Expand All @@ -20,7 +20,7 @@ const Footer = () => (
/>
</a>
</div>
<p className="mx-auto text-[15px] leading-[1.6] text-[#333333] dark:text-[#e0e0e0] [&_a]:text-[#3b7eb5] [&_a:hover]:!text-[#144f80] dark:[&_a:hover]:!text-[#82b7f6]">
<p className="mx-auto text-[15px] leading-[1.6] text-[#333333] dark:text-[#e0e0e0]">
Copyright <a href="https://openjsf.org">OpenJS Foundation</a> and
webpack contributors. All rights reserved. The{" "}
<a href="https://openjsf.org">OpenJS Foundation</a> has registered
Expand All @@ -36,12 +36,9 @@ const Footer = () => (
holders. Use of them does not imply any affiliation with or endorsement
by them.
</p>
<p className="mx-auto mt-[18px] text-[15px] leading-[1.6] text-[#333333] dark:text-[#e0e0e0] [&_a]:text-[#3b7eb5] [&_a:hover]:!text-[#144f80] dark:[&_a:hover]:!text-[#82b7f6]">
<p className="mx-auto mt-[18px] text-[15px] leading-[1.6] text-[#333333] dark:text-[#e0e0e0]">
<a href="https://openjsf.org">The OpenJS Foundation</a> |{" "}
<a href="https://ai-coding-assistants-policy.openjsf.org/">
AI Coding Assistants Policy
</a>{" "}
| <a href="https://terms-of-use.openjsf.org">Terms of Use</a> |{" "}
<a href="https://terms-of-use.openjsf.org">Terms of Use</a> |{" "}
<a href="https://privacy-policy.openjsf.org">Privacy Policy</a> |{" "}
<a href="https://bylaws.openjsf.org">Bylaws</a> |{" "}
<a href="https://code-of-conduct.openjsf.org">Code of Conduct</a> |{" "}
Expand Down
41 changes: 40 additions & 1 deletion src/components/Markdown/Markdown.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,8 @@
font-family:
"Source Code Pro", Consolas, "Liberation Mono", Menlo, Courier, monospace;
@apply text-[90%] mx-0.5 py-0.5 px-1.5 whitespace-normal bg-[rgba(70,94,105,0.05)] rounded-[3px];
text-shadow: 0 1px 0 rgba(255, 255, 255, 0.6);
color: var(--color-code-inline-text);
text-shadow: none;
}

a {
Expand Down Expand Up @@ -455,3 +456,41 @@
.dark .markdown aside.todo > .todo__prefix {
@apply text-white;
}

.markdown aside.tip p a,
.markdown aside.tip li a {
@apply text-link-accessible;
}

.markdown aside.tip p a:hover,
.markdown aside.tip li a:hover {
@apply text-link-accessible-hover;
}

.dark .markdown aside.tip p a,
.dark .markdown aside.tip li a {
@apply text-link-accessible-dark;
}

.markdown p a > code,
.markdown li a > code,
.markdown aside a > code,
.markdown p a > tt,
.markdown li a > tt,
.markdown aside a > tt {
@apply text-link-accessible;
background: transparent;
padding: 0;
margin: 0;
border-radius: 0;
text-shadow: none;
}

.dark .markdown p a > code,
.dark .markdown li a > code,
.dark .markdown aside a > code,
.dark .markdown p a > tt,
.dark .markdown li a > tt,
.dark .markdown aside a > tt {
@apply text-link-accessible-dark;
}
2 changes: 1 addition & 1 deletion src/components/Navigation/Navigation.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ function Navigation({ links, pathname, hash = "", toggleSidebar }) {
>
{link.children.map((child) => {
const classNames =
"text-blue-400 dark:text-[#69a8ee] py-5 text-sm capitalize hover:text-black dark:hover:text-white";
"text-[var(--color-link-accessible)] dark:text-[var(--color-link-accessible-dark)] py-5 text-sm capitalize hover:text-[var(--color-link-accessible-hover)] dark:hover:text-white";
const isActive = location.pathname.startsWith(child.url);
return (
<NavLink
Expand Down
10 changes: 8 additions & 2 deletions src/styles/theme.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
--color-brand-link-hover: #144f80;
--color-brand-link-dark: #69a8ee;
--color-brand-link-dark-hover: #82b7f6;
/* Accessible link colors (a11y fix) */
--color-link-accessible: #175d96;
--color-link-accessible-hover: #144f80;

/* Brand button/UI blue */
--color-brand-blue: #175d96;
Expand All @@ -15,7 +18,7 @@
/* Aside/callout colors */
--color-aside-border: #dddddd;
--color-aside-tip-bg: #eaf8ff;
--color-aside-tip-text: #4e7182;
--color-aside-tip-text: #465e69;
--color-aside-tip-border: #1eb4ff;
--color-aside-warning-bg: #fdf5d8;
--color-aside-warning-text: #716b53;
Expand All @@ -37,6 +40,7 @@
--color-code-link: #1e78c2;
--color-code-link-hover: #2186d8;
--color-code-anchor-border: #175d96;
--color-code-inline-text: #144f80;

/* Dark mode surface colors */
--color-dark-bg: #121212;
Expand All @@ -61,6 +65,8 @@
--color-dark-section-border: #343434;
--color-dark-sidebar-text: #cadbe6;
--color-dark-active-text: #465e69;
--color-link-accessible-dark: #8dd6f9;
--color-dark-code-inline-text: #e2e8f0;

/* Sidebar/nav */
--color-nav-bg: #526b78;
Expand All @@ -82,7 +88,7 @@
--color-heading-dark: #32434a;
--color-aside-border: #dddddd;
--color-aside-tip-bg: #eaf8ff;
--color-aside-tip-text: #4e7182;
--color-aside-tip-text: #465e69;
--color-aside-tip-border: #1eb4ff;
--color-aside-warning-bg: #fdf5d8;
--color-aside-warning-text: #716b53;
Expand Down
Loading