-
-
Notifications
You must be signed in to change notification settings - Fork 64
Add "QA Rating" filter to archived item list #3136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
|
@SocketSecurity ignore npm/replaywebpage@2.2.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Overall looks good, just a few small things.
Change error detail to snake case for front-end localization Co-authored-by: Tessa Walsh <tessa@bitarchivist.net>
Co-authored-by: Tessa Walsh <tessa@bitarchivist.net>
deleted in cleanup
…github.com/webrecorder/browsertrix into 2875-task-add-filtering-by-qa-review-score
idk why else they would still be showing up in search value results
SuaYoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool idea! Left some small suggestions.
In general, I think it makes more sense to name this filter "QA Rating"/"Filter by QA Rating". The filter being named "QA Review" makes me think I should be able to filter by reviewed/not reviewed. "Rating" also makes more sense with the range slider. We do use this terminology and label the radio buttons as "Rate this crawl":
Fixes to missed tailwind classes, types, and improved url state parsing Co-authored-by: sua yoo <sua@webrecorder.org>
tw4l
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Very nice addition to the frontend, and thanks for the crawlconfig search values fix :)
Co-authored-by: Tessa Walsh <tessa@bitarchivist.net>
Co-authored-by: Tessa Walsh <tessa@bitarchivist.net>

Closes #2875
Changes
Adds a filter for review state to the archived item list.
The filter uses a Web Awesome component, so this PR includes importing the Web Awesome CSS as well as its Slider component, which adds about 216kb of code to the final output.
Also excludes inactive workflows from the search values query, which will prevent searching for deleted workflows.
Demo
Screen.Recording.2026-01-26.at.1.26.05.PM.mov
Testing
Tested locally, and back-end changes are tested via integration test