Skip to content

Conversation

@emma-sg
Copy link
Member

@emma-sg emma-sg commented Jan 26, 2026

Closes #2875

Changes

Adds a filter for review state to the archived item list.

The filter uses a Web Awesome component, so this PR includes importing the Web Awesome CSS as well as its Slider component, which adds about 216kb of code to the final output.

Also excludes inactive workflows from the search values query, which will prevent searching for deleted workflows.

Demo

Screen.Recording.2026-01-26.at.1.26.05.PM.mov

Testing

Tested locally, and back-end changes are tested via integration test

@emma-sg emma-sg linked an issue Jan 26, 2026 that may be closed by this pull request
@socket-security
Copy link

socket-security bot commented Jan 26, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​awesome.me/​webawesome@​3.1.0921007990100

View full report

@socket-security
Copy link

socket-security bot commented Jan 26, 2026

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

@emma-sg emma-sg marked this pull request as ready for review January 26, 2026 19:08
@emma-sg emma-sg requested review from SuaYoo and tw4l January 26, 2026 19:09
@emma-sg
Copy link
Member Author

emma-sg commented Jan 26, 2026

@SocketSecurity ignore npm/replaywebpage@2.2.4

Copy link
Member

@tw4l tw4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Overall looks good, just a few small things.

emma-sg and others added 2 commits January 27, 2026 15:06
Change error detail to snake case for front-end localization

Co-authored-by: Tessa Walsh <tessa@bitarchivist.net>
Copy link
Member

@SuaYoo SuaYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool idea! Left some small suggestions.

In general, I think it makes more sense to name this filter "QA Rating"/"Filter by QA Rating". The filter being named "QA Review" makes me think I should be able to filter by reviewed/not reviewed. "Rating" also makes more sense with the range slider. We do use this terminology and label the radio buttons as "Rate this crawl":

Image

emma-sg and others added 3 commits January 28, 2026 19:44
Fixes to missed tailwind classes, types, and improved url state parsing

Co-authored-by: sua yoo <sua@webrecorder.org>
@emma-sg emma-sg changed the title Add filter by review state to archived item list Add "QA Rating" filter to archived item list Jan 29, 2026
@emma-sg
Copy link
Member Author

emma-sg commented Jan 29, 2026

Updated filter name to "QA Rating"

Screenshot 2026-01-28 at 7 58 18 PM Screenshot 2026-01-28 at 7 58 25 PM

@emma-sg emma-sg requested review from SuaYoo and tw4l January 29, 2026 05:17
Copy link
Member

@tw4l tw4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Very nice addition to the frontend, and thanks for the crawlconfig search values fix :)

emma-sg and others added 2 commits January 29, 2026 13:28
Co-authored-by: Tessa Walsh <tessa@bitarchivist.net>
Co-authored-by: Tessa Walsh <tessa@bitarchivist.net>
@emma-sg emma-sg merged commit 5de23f9 into main Jan 29, 2026
29 checks passed
@emma-sg emma-sg deleted the 2875-task-add-filtering-by-qa-review-score branch January 29, 2026 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task]: Add filtering by QA review score

4 participants