Skip to content

Fix acronym snake case in generated C names#5

Merged
tolgahan-arikan merged 2 commits into
masterfrom
fix-acronym-snake-case
Apr 17, 2026
Merged

Fix acronym snake case in generated C names#5
tolgahan-arikan merged 2 commits into
masterfrom
fix-acronym-snake-case

Conversation

@tolgahan-arikan
Copy link
Copy Markdown
Collaborator

What changed

  • normalized acronym boundaries before snake-casing generated C symbols
  • updated type, enum, service, method, and field naming paths to keep names like EOAWalletData, OIDCAuth, and ExchangeID split correctly
  • added a regression test covering generated type, field, and method names for acronym-heavy schema identifiers

Why

The generator was feeding raw schema names directly into snakeCase. For identifiers with an uppercase acronym followed by a normal PascalCase word, that produced broken splits such as EOAWalletData -> eoaw_allet_data.

Impact

This fixes the generated C client surface so symbol names and struct member names are consistent and readable. It does not change wire format, request paths, JSON field names, enum wire values, or transport behavior.

Validation

  • go test ./...

@tolgahan-arikan tolgahan-arikan marked this pull request as ready for review April 17, 2026 12:10
@tolgahan-arikan tolgahan-arikan merged commit 50af4f4 into master Apr 17, 2026
2 checks passed
@tolgahan-arikan tolgahan-arikan deleted the fix-acronym-snake-case branch April 17, 2026 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant