Ensure cookbooks path exists before merging#15
Open
samumbach wants to merge 1 commit intowebsterclay:masterfrom
Open
Ensure cookbooks path exists before merging#15samumbach wants to merge 1 commit intowebsterclay:masterfrom
samumbach wants to merge 1 commit intowebsterclay:masterfrom
Conversation
Under the following circumstances, the cookbooks path will not exist after the call to reset_to_default_state. In this instance, the directory should be created before attempting to merge the new cookbook. - cookbooks path is an empty subdirectory within an existing git repo (e.g, my_project/cookbooks) - user attempts to install a cookbook `cd my_project; knife cookbook github install --cookbook-path cookbooks cookbooks/yum` - knife clones the cookbook from github and commits it to a vendor branch - upon switching back to the master branch, the (previously empty) cookbooks directory will no longer exist In this instance, it should be safe to create the previously extant directory so the merge can be completed.
Author
|
I've observed this same behavior with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under the following circumstances, the cookbooks path will not exist after the
call to reset_to_default_state. In this instance, the directory should be
created before attempting to merge the new cookbook.
cd my_project; knife cookbook github install --cookbook-path cookbooks cookbooks/yumIn this instance, it should be safe to create the previously extant directory so the merge can be completed.