Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
6 issues found across 32 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Add the Android SDK to serve
.wvbbundles inWebView, plus a minimal test app and CI-backed end-to-end tests. Pin the FFI version for reproducible installs.New Features
:lib:WebViewBundlewith request interception forhttps://<bundle>.wvb/*,WebViewBundleClient,WebViewBundleProtocol(passthrough rules), andBundleSourcewith Android defaults for builtin/remote bundles.WebViewSetup: recommendedWebViewsettings and optional service-worker interception viaandroidx.webkit; safe defaults with an escape hatch for custom tweaks.:testapp: installs the library into a full-screenWebViewand loads the builtinhacker-newsbundle fromassets/bundlesathttps://hacker-news.wvb/.e2e/: Appium + WebdriverIO + Vitest run shared@wvb-playground/webview-hacker-newstests; APK built in global setup; emulator + drivers managed programmatically; CI workflow builds:lib/:testappand runs the suite on Linux with KVM.androidx.annotation,androidx.webkit, andkotlinx-coroutines-android; switch JNA to the Android AAR (net.java.dev.jna:jna:<version>@aar); increase Gradle daemon heap/metaspace; enableandroid.useAndroidX=true.Bug Fixes
lib/lint.xmlto ignore a false NewApi warning in generatedwvb_ffi.kt, fixing release lint in CI.Written for commit 3b385c9. Summary will update on new commits.