Conversation
There was a problem hiding this comment.
4 issues found and verified against the latest diff
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="Sources/WebViewBundle/WebViewBundleSchemeHandler.swift">
<violation number="1" location="Sources/WebViewBundle/WebViewBundleSchemeHandler.swift:45">
P2: Stopped scheme tasks are not actually cancelled. This can waste work and still run request-side effects after `stop` is called.</violation>
</file>
<file name="Sources/WebViewBundle/WebViewBundle.swift">
<violation number="1" location="Sources/WebViewBundle/WebViewBundle.swift:49">
P1: Scheme validation is incomplete: non-empty but native/invalid schemes are accepted and can crash at handler registration.</violation>
<violation number="2" location="Sources/WebViewBundle/WebViewBundle.swift:50">
P2: Duplicate scheme check is case-sensitive; case variants can pass init and fail at runtime during registration.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
|
|
||
| // Inherits the main actor; the `await` lets the FFI handler run off-main | ||
| // (it is `nonisolated`) and resumes here back on the main actor. | ||
| Task { |
There was a problem hiding this comment.
P2: Stopped scheme tasks are not actually cancelled. This can waste work and still run request-side effects after stop is called.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At Sources/WebViewBundle/WebViewBundleSchemeHandler.swift, line 45:
<comment>Stopped scheme tasks are not actually cancelled. This can waste work and still run request-side effects after `stop` is called.</comment>
<file context>
@@ -0,0 +1,83 @@
+
+ // Inherits the main actor; the `await` lets the FFI handler run off-main
+ // (it is `nonisolated`) and resumes here back on the main actor.
+ Task {
+ let result: Result<HttpResponse, any Swift.Error>
+ do {
</file context>
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="Sources/WebViewBundle/WebViewBundleSchemeHandler.swift">
<violation number="1" location="Sources/WebViewBundle/WebViewBundleSchemeHandler.swift:45">
P2: Stopped scheme tasks are not actually cancelled. This can waste work and still run request-side effects after `stop` is called.</violation>
</file>
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Implements the iOS
WebViewBundleSwift library to serve.wvbbundles inWKWebViewvia custom URL schemes, adds a Tuist TestApp, and wires unit + Appium/Vitest E2E tests into CI.New Features
WebViewBundleregistersWKURLSchemeHandler, builds configuredWKWebViews, exposesschemes, and supportsonError.WebViewBundleProtocoladds.bundle(scheme:)and.local(scheme:hosts:)with empty/invalid/reserved/duplicate scheme checks.BundleSource.makeprovides iOS/macOS defaults and creates a writable Application Support dir scoped by bundle id.HttpMethod.fromandHttpResponse→HTTPURLResponsehelpers.WebViewBundleConfig,WebViewBundleUpdaterConfig,WebViewBundleRemoteConfig) withwebViewBundle(_:)/wvb(_:)optionally wiringRemote/Updater.testapp://hacker-news.wvb; unit tests cover serving/validation; E2E runs via Appium/Vitest; CI runsswift testand E2E on macOS.Dependencies
Package.swiftpinsWebViewBundleFFItoprerelease/4513cabwith checksum, setsswift-tools-versionto 6.1, and linksSystemConfiguration,Security, andCoreFoundation.Written for commit 1d1651f. Summary will update on new commits.