Fix #151: Allow mixed comma and whitespace separation in transform pa…#152
Open
shiinapple wants to merge 1 commit intoweisJ:masterfrom
Open
Fix #151: Allow mixed comma and whitespace separation in transform pa…#152shiinapple wants to merge 1 commit intoweisJ:masterfrom
shiinapple wants to merge 1 commit intoweisJ:masterfrom
Conversation
weisJ
reviewed
Feb 14, 2026
| ListSplitter.SplitResult result = splitter.testChar(c, i - start); | ||
| if (result.shouldSplit()) { | ||
| list.add(value.substring(start, i)); | ||
| if (i - start > 0) list.add(value.substring(start, i)); |
Owner
There was a problem hiding this comment.
I think this might allow 1,,1 to be parsed as a list of only two strings, while it should really contain the empty string. Can we instead make sure to only avoid splitting while we are seeing whitespace directly after encountering a non whitespace delimiter?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified ParserUtil.java to add a guard
if (i - start > 0)before adding tokens to the list. This ensures that consecutive separators (e.g., "-1 , 1") do not produce empty strings, which previously caused parsing failures.Added two tests in AttributeParserTest.java:
Both tests now pass correctly.
This is my first pr. Please let me know if anything needs to be adjusted!