feat: upgrade go-weka-observability lib and go version#19
Open
kristina-solovyova wants to merge 1 commit intomainfrom
Open
feat: upgrade go-weka-observability lib and go version#19kristina-solovyova wants to merge 1 commit intomainfrom
kristina-solovyova wants to merge 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the project’s observability integration and module/toolchain versions to align with newer go-weka-observability and OpenTelemetry APIs.
Changes:
- Replaced deprecated
instrumentation.GetLogSpanusage withCreateLogSpan/CurrentSpanLoggeracross lifecycle code paths. - Updated OTel SDK setup calls to
SetupOTelSDKWithOptionsin examples and tests. - Bumped Go/module dependencies (including
go-weka-observability,otel, and related indirect deps) and refreshedgo.sum.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| lifecycle/step_engine_test.go | Switch test logging/OTel setup to new SDK setup API. |
| lifecycle/step_engine.go | Migrate span creation/logger retrieval to new instrumentation APIs. |
| lifecycle/parallel_steps.go | Migrate parallel step spans to CreateLogSpan. |
| lifecycle/k8s.go | Migrate condition-update spans and reconciler logger retrieval to new APIs. |
| examples/shared/logging.go | Update example OTel setup to new SDK setup API. |
| go.mod | Upgrade Go version and key dependencies (OTel, observability lib, etc.). |
| go.sum | Dependency checksum updates from the module upgrades. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kristina-solovyova
force-pushed
the
03-24-feat_upgrade_go-weka-observability_lib_and_go_version
branch
from
51e20d1 to
bea1be2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.