Skip to content

add necessary logs #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
assafgi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add necessary logs #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions talker/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,10 @@ def redis_params(self):
port=int(self._port)
)

@property
def name(self):
return self._name

@cached_property
def redis(self):
"""
Expand Down
1 change: 1 addition & 0 deletions talker/command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,6 +474,7 @@ def check_client_timeout(self):
exception_cls = TalkerCommandLost if talker_alive else TalkerServerTimeout
self.raise_exception(exception_cls=exception_cls, timeout=self.ack_timer.elapsed)
elif self.client_timer.expired:
_verbose_logger.debug("Client command timeout (%s)", self)
self.raise_exception(
exception_cls=ClientCommandTimeoutError, timeout=self.ack_timer.elapsed, started=self.since_started
)
Expand Down
2 changes: 2 additions & 0 deletions talker/reactor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ def _send_data(self, items):
for item in items:
redis_func = getattr(pipeline, item.cmd)
redis_func(*item.args, **item.kwargs)
_verbose_logger.debug(
'Executing talker %s redis %s pipeline', self.talker.name, self.talker.redis_params['host'])
results = pipeline.execute()
assert len(results) == len(items), "Our redis pipeline got out of sync?"
self._log_sent_items(items) # logs to debug WEKAPP-35305
Expand Down