Conversation
How to use the Graphite Merge QueueAdd the label main-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Graphite Automations"Add anton/matt/sergey/kristina as reviwers on operator PRs" took an action on this PR • (07/02/25)3 reviewers were added to this PR based on Anton Bykov's automation. |
rugggger
force-pushed
the
07-02-feat_sign_gcp_all_drives
branch
from
771ce46 to
f7a1188
Compare
| serial_id_path = "/".join(pci_device_path.split("/")[:-2]) + "/serial" | ||
| serial_id = subprocess.check_output(f"cat {serial_id_path}", shell=True).decode().strip() | ||
| device_path = "/dev/" + pci_device_path.split("/")[-2] | ||
| if is_google_cos() and (not serial_id or serial_id == "nvme_card"): |
There was a problem hiding this comment.
isn't it enough to check for google_cos?
There was a problem hiding this comment.
If I remember correctly there are other devices there of different types and you want only the nvme_card ones
There was a problem hiding this comment.
but here you cover both cases that it is nvme and not, since you cover also not serial_id
| if not serial_id: | ||
| logging.warning(f"lsblk did not return serial for {device_path}. Using fallback.") | ||
| serial_id = await get_serial_id_fallback(device_path) | ||
| if serial_id == "nvme_card": |
There was a problem hiding this comment.
why is this needed? you already have above handle for google cos
There was a problem hiding this comment.
Since you expect to get here only for cos, you should just call here :
if is_google_cos():
logging.info(f"Using COS-specific method for {device_name}")
serial_id = await get_serial_id_cos_specific(device_name)
if serial_id:
return serial_id
There was a problem hiding this comment.
I don't know for sure that if the device name is "nvme_card" that it is COS. I know that it is not a valid name and so I will direct the call to a fallback.
In the fallback function itself I treat different cases, including is_google_cos
There was a problem hiding this comment.
instead of having it in the fallback, check here for cos and have it here directly
rugggger
force-pushed
the
07-02-feat_sign_gcp_all_drives
branch
2 times, most recently
from
11fc1f2 to
81968c0
Compare
rugggger
force-pushed
the
07-02-feat_sign_gcp_all_drives
branch
from
81968c0 to
161a799
Compare
Merge activity
|
2 participants
sign "gcp_all" drives (for Google GKE cluster)
<release_notes>
Sign all GCP drives for GKE clusters
Type: feature
Added support for automatically signing all eligible drives on GCP GKE nodes based on vendor and device IDs. Use
type: gcp-allin thesignDrivesPayloadof a WekaManualOperation.</release_notes>