feat: add smbw support by assafgi · Pull Request #2104 · weka/weka-operator

assafgi · 2026-01-22T07:00:03Z

No description provided.

assafgi · 2026-01-22T07:00:38Z

How to use the Graphite Merge Queue

Add the label main-merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has required the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

graphite-app · 2026-01-22T07:05:12Z

Graphite Automations

"Add anton/matt/sergey/kristina as reviwers on operator PRs" took an action on this PR • (01/22/26)

2 reviewers were added to this PR based on Anton Bykov's automation.

kristina-solovyova · 2026-01-22T09:19:49Z

internal/controllers/wekacluster/funcs_smbw.go

+	smbwCluster, err := wekaService.GetSmbwCluster(ctx)
+	if err != nil {
+		err = errors.Wrap(err, "Failed to get SMB-W cluster")
+		return err
+	}
+
+	if smbwCluster.Active {
+		logger.Info("SMB-W cluster already exists")
+		return nil
+	}


it looks like EnsureSmbwCluster expects smbw cluster to be already created and will otherwise

kristina-solovyova · 2026-01-22T09:25:47Z

internal/controllers/wekacluster/funcs_smbw.go

+func contains(s, substr string) bool {
+	return len(s) >= len(substr) && (s == substr || len(s) > 0 && containsIgnoreCase(s, substr))
+}


ah, it's for containsIgnoreCase
then maybe would be good to remove this "contains" func and only keep "containsIgnoreCase"

Copilot

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-24T09:46:56Z

internal/controllers/resources/pod.go

+					shmSizeLimit := resource.MustParse(config.Config.Smbw.ShmSize)
+					vols = append(vols, corev1.Volume{
+						Name: "smbw-shm",
+						VolumeSource: corev1.VolumeSource{
+							EmptyDir: &corev1.EmptyDirVolumeSource{
+								Medium:    corev1.StorageMediumMemory,
+								SizeLimit: &shmSizeLimit,


resource.MustParse(config.Config.Smbw.ShmSize) will panic if the SMBW_SHM_SIZE env/Helm value is invalid, potentially crashing the operator. Prefer resource.ParseQuantity (or validation during env config) and return/log a clear error instead of panicking.

Suggested change

shmSizeLimit := resource.MustParse(config.Config.Smbw.ShmSize)

vols = append(vols, corev1.Volume{

Name: "smbw-shm",

VolumeSource: corev1.VolumeSource{

EmptyDir: &corev1.EmptyDirVolumeSource{

Medium: corev1.StorageMediumMemory,

SizeLimit: &shmSizeLimit,

var shmSizeLimit *resource.Quantity

if q, err := resource.ParseQuantity(config.Config.Smbw.ShmSize); err != nil {

fmt.Printf("invalid SMBW_SHM_SIZE value %q, using unlimited shm size: %v\n", config.Config.Smbw.ShmSize, err)

} else {

shmSizeLimit = &q

}

vols = append(vols, corev1.Volume{

Name: "smbw-shm",

VolumeSource: corev1.VolumeSource{

EmptyDir: &corev1.EmptyDirVolumeSource{

Medium: corev1.StorageMediumMemory,

SizeLimit: shmSizeLimit,

Copilot · 2026-03-24T09:46:57Z

internal/controllers/wekacluster/funcs_upgrade.go

+		if prepareForUpgrade {
+			err := r.prepareForUpgradeS3(ctx, smbwContainers, targetVersion)
+			if err != nil {


prepareForUpgradeS3 is now used for SMB-W containers as well. Even if the underlying logic is valid (it appears to prepare the “frontend” upgrade phase), the name is misleading and makes the SMB-W upgrade path harder to understand. Consider renaming to something frontend-generic or adding a dedicated wrapper for SMB-W that calls the shared helper.

Copilot

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-25T07:48:26Z

internal/controllers/wekacluster/funcs_smbw.go

+	cmd := fmt.Sprintf("weka smb domain join %s %s", username, password)
+	_, stderr, err := executor.ExecSensitive(ctx, "JoinSmbwDomain", []string{"bash", "-ce", cmd})
+	if err != nil {
+		stderrStr := stderr.String()


The domain-join command is built via string interpolation and executed through bash -ce, which allows shell injection if the username/password contain shell metacharacters (and will also break on spaces). Prefer calling the executable directly with an argv slice (e.g., []string{"weka", "smb", "domain", "join", username, password}) so inputs are not interpreted by a shell.

Suggested change

cmd := fmt.Sprintf("weka smb domain join %s %s", username, password)

_, stderr, err := executor.ExecSensitive(ctx, "JoinSmbwDomain", []string{"bash", "-ce", cmd})

if err != nil {

stderrStr := stderr.String()

_, stderr, err := executor.ExecSensitive(ctx, "JoinSmbwDomain", []string{"weka", "smb", "domain", "join", username, password})

if err != nil {

stderrStr := stderr.String()

stderrStr := stderr.String()

Copilot · 2026-03-25T07:48:27Z

internal/controllers/wekacluster/funcs_smbw.go

+	smbwContainers := r.SelectSmbwContainers(r.containers)
+	containerIds := []int{}
+	for _, c := range smbwContainers {
+		if len(containerIds) == config.Consts.FormSmbwClusterMaxContainerCount {
+			logger.Debug("Max SMB-W containers reached for initial SMB-W cluster creation", "maxContainers", config.Consts.FormSmbwClusterMaxContainerCount)
+			break
+		}
+
+		if c.Status.ClusterContainerID == nil {
+			msg := fmt.Sprintf("SMB-W container %s does not have a cluster container id", c.Name)
+			logger.Debug(msg)
+			continue
+		}
+		containerIds = append(containerIds, *c.Status.ClusterContainerID)
+	}


SMB-W cluster creation selects all SMB-W containers from r.containers without filtering for running/ready state. This can include terminating/not-yet-running containers and lead to using stale ClusterContainerIDs or waiting indefinitely. Consider mirroring the S3 logic (discovery.SelectRunningContainersByRole or equivalent) so only running SMB-W containers with valid IDs are considered for initial cluster formation.

Copilot · 2026-03-25T07:48:27Z

internal/controllers/wekacluster/steps_post_cluster.go

+		&lifecycle.SimpleStep{
+			Predicates: lifecycle.Predicates{
+				loop.HasSmbwContainers,
+			},
+			State: &lifecycle.State{
+				Name: condition.CondSmbwClusterCreated,
+			},
+			Run: loop.EnsureSmbwCluster,


These SMB-W post-cluster steps are gated by HasSmbwContainers, which (as currently implemented) counts all SMB-W CRs, not just running/ready ones. This differs from the S3/NFS gating (HasRunning...Containers) and can cause repeated waits or re-creation attempts during scale-down/deletion. Consider gating on running SMB-W containers (or adding a HasRunningSmbwContainers predicate) to match the established pattern.

Copilot · 2026-03-25T07:48:27Z

internal/controllers/wekacluster/funcs_upgrade.go

+			}
+		}
+		if prepareForUpgrade {
+			err := r.prepareForUpgradeS3(ctx, smbwContainers, targetVersion)


This upgrade path reuses prepareForUpgradeS3 for SMB-W containers. That helper logs/labels itself as S3 and hardcodes the "frontend" upgrade phase; if SMB-W uses a distinct upgrade phase or you rely on logs/metrics for debugging, this will be misleading or incorrect. Consider introducing a generic prepareForUpgradeFrontend helper (or a dedicated SMB-W variant) and using the correct naming/phase.

Suggested change

err := r.prepareForUpgradeS3(ctx, smbwContainers, targetVersion)

err := r.prepareForUpgradeFrontend(ctx, smbwContainers, targetVersion)

Copilot

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-25T12:50:31Z

internal/controllers/allocator/templates.go

 		Drive:        config.DriveContainers,
 		S3:           config.S3Containers,
 		Nfs:          config.NfsContainers,
+		Smbw:		  config.SmbwContainers,


There is inconsistent indentation/alignment in this struct literal (e.g., tabs/spaces around the Smbw field). Please run gofmt on the file to keep formatting consistent and avoid noisy diffs later.

Suggested change

Smbw: config.SmbwContainers,

Smbw: config.SmbwContainers,

graphite-app · 2026-03-25T13:38:35Z

Merge activity

Mar 25, 1:38 PM UTC: assafgi added this pull request to the Graphite merge queue.
Mar 25, 1:39 PM UTC: CI is running for this pull request on a draft pull request (#2396) due to your merge queue CI optimization settings.
Mar 25, 5:10 PM UTC: Merged by the Graphite merge queue via draft PR: #2396.

assafgi marked this pull request as ready for review January 22, 2026 07:00

graphite-app bot requested review from kristina-solovyova and tigrawap January 22, 2026 07:00

assafgi force-pushed the 01-21-feat_add_smbw_support branch from 6660290 to 295e9ec Compare January 22, 2026 08:07

kristina-solovyova reviewed Jan 22, 2026

View reviewed changes

assafgi force-pushed the 01-21-feat_add_smbw_support branch from 295e9ec to 5516b89 Compare January 22, 2026 10:54

assafgi requested a review from a team as a code owner January 28, 2026 18:09

assafgi force-pushed the 01-21-feat_add_smbw_support branch 13 times, most recently from dd13517 to 607f4de Compare February 11, 2026 11:32

assafgi force-pushed the 01-21-feat_add_smbw_support branch 5 times, most recently from 3ecc1ad to ff27dc2 Compare February 16, 2026 13:59

assafgi force-pushed the 01-21-feat_add_smbw_support branch from ff27dc2 to 4b43eff Compare February 24, 2026 10:41

Copilot AI review requested due to automatic review settings March 5, 2026 09:15

Copilot started reviewing on behalf of assafgi March 24, 2026 09:42 View session

Copilot AI reviewed Mar 24, 2026

View reviewed changes

assafgi force-pushed the 01-21-feat_add_smbw_support branch from e9a70f7 to f4fc165 Compare March 24, 2026 10:38

Copilot AI review requested due to automatic review settings March 24, 2026 10:40

assafgi force-pushed the 01-21-feat_add_smbw_support branch from f4fc165 to c268bd8 Compare March 24, 2026 10:40

Copilot started reviewing on behalf of assafgi March 24, 2026 10:40 View session

Copilot AI reviewed Mar 24, 2026

View reviewed changes

assafgi force-pushed the 01-21-feat_add_smbw_support branch from c268bd8 to f7f59e1 Compare March 24, 2026 10:47

Copilot AI review requested due to automatic review settings March 24, 2026 12:53

assafgi force-pushed the 01-21-feat_add_smbw_support branch from f7f59e1 to 1aeefab Compare March 24, 2026 12:53

Copilot started reviewing on behalf of assafgi March 24, 2026 12:53 View session

Copilot AI reviewed Mar 24, 2026

View reviewed changes

assafgi force-pushed the 01-21-feat_add_smbw_support branch from 1aeefab to c6d9a0b Compare March 24, 2026 15:40

Copilot AI review requested due to automatic review settings March 24, 2026 15:47

assafgi force-pushed the 01-21-feat_add_smbw_support branch from c6d9a0b to 84ce4d9 Compare March 24, 2026 15:47

Copilot started reviewing on behalf of assafgi March 24, 2026 15:48 View session

Copilot AI reviewed Mar 24, 2026

View reviewed changes

assafgi force-pushed the 01-21-feat_add_smbw_support branch from 84ce4d9 to 021caef Compare March 24, 2026 19:53

Copilot AI review requested due to automatic review settings March 25, 2026 07:40

assafgi force-pushed the 01-21-feat_add_smbw_support branch from 021caef to d310f51 Compare March 25, 2026 07:40

Copilot started reviewing on behalf of assafgi March 25, 2026 07:40 View session

Copilot AI reviewed Mar 25, 2026

View reviewed changes

assafgi force-pushed the 01-21-feat_add_smbw_support branch from d310f51 to 0235f70 Compare March 25, 2026 08:17

kristina-solovyova mentioned this pull request Mar 25, 2026

fix: propagate numCores and extraCores from wekacluster to wekacontainers per role (OP-260) #2395

Open

feat: add smbw support

e1ff068

Copilot AI review requested due to automatic review settings March 25, 2026 12:45

assafgi force-pushed the 01-21-feat_add_smbw_support branch from 0235f70 to e1ff068 Compare March 25, 2026 12:45

Copilot AI reviewed Mar 25, 2026

View reviewed changes

kristina-solovyova approved these changes Mar 25, 2026

View reviewed changes

	err := r.prepareForUpgradeS3(ctx, smbwContainers, targetVersion)
	err := r.prepareForUpgradeFrontend(ctx, smbwContainers, targetVersion)

Conversation

assafgi commented Jan 22, 2026

Uh oh!

assafgi commented Jan 22, 2026 • edited by kristina-solovyova Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

graphite-app bot commented Jan 22, 2026

Graphite Automations

Uh oh!

kristina-solovyova Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

kristina-solovyova Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 25, 2026

Choose a reason for hiding this comment

Uh oh!

graphite-app bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

assafgi commented Jan 22, 2026 •

edited by kristina-solovyova

Loading

graphite-app bot commented Mar 25, 2026 •

edited

Loading