fix: add UpdatableClusterSpec to the podConfig hash#2315
Closed
rugggger wants to merge 1 commit into02-26-fix_rotate_pods_on_pod-config_changefrom
Closed
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label main-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Graphite Automations"Add anton/matt/sergey/kristina as reviwers on operator PRs" took an action on this PR • (03/04/26)3 reviewers were added to this PR based on Anton Bykov's automation. |
| } | ||
|
|
||
| func NewPodFactory(container *weka.WekaContainer, nodeInfo *discovery.DiscoveryNodeInfo) *PodFactory { | ||
| func NewPodFactory(container *weka.WekaContainer, nodeInfo *discovery.DiscoveryNodeInfo, cluster *weka.WekaCluster) *PodFactory { |
Collaborator
There was a problem hiding this comment.
maybe let's just pass podConfigHash string param here directly ?
I see cluster is used only for this call later: PodConfigHashForCluster(f.cluster)
rugggger
force-pushed
the
03-04-fix_add_updatableclusterspec_to_the_podconfig_hash
branch
from
54e6bc4 to
0a95ca0
Compare
rugggger
force-pushed
the
02-26-fix_rotate_pods_on_pod-config_change
branch
from
d3da503 to
fda9371
Compare
rugggger
force-pushed
the
03-04-fix_add_updatableclusterspec_to_the_podconfig_hash
branch
from
0a95ca0 to
4c2eb1a
Compare
rugggger
force-pushed
the
02-26-fix_rotate_pods_on_pod-config_change
branch
from
fda9371 to
5ae7f5f
Compare
rugggger
force-pushed
the
03-04-fix_add_updatableclusterspec_to_the_podconfig_hash
branch
from
4c2eb1a to
486b6d3
Compare
rugggger
force-pushed
the
02-26-fix_rotate_pods_on_pod-config_change
branch
from
5ae7f5f to
8f6b3af
Compare
rugggger
force-pushed
the
03-04-fix_add_updatableclusterspec_to_the_podconfig_hash
branch
from
486b6d3 to
5810044
Compare
rugggger
force-pushed
the
02-26-fix_rotate_pods_on_pod-config_change
branch
from
8f6b3af to
05be919
Compare
rugggger
force-pushed
the
03-04-fix_add_updatableclusterspec_to_the_podconfig_hash
branch
from
5810044 to
c35862f
Compare
rugggger
force-pushed
the
02-26-fix_rotate_pods_on_pod-config_change
branch
from
05be919 to
a98748c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Enhanced pod configuration hash calculation to include cluster specification data, ensuring pods are rotated when cluster configuration changes.
What changed?
PodConfigHash()toPodConfigHashForCluster()that accepts a cluster parameter and includes cluster specification in the hash calculationUpdatableClusterSpecstruct to the resources package and moved it from the wekacluster controllerPodFactoryto store a cluster reference and use it for configuration hash generationNewPodFactorycalls to pass the cluster parameterWhy make this change?
This change ensures that pods are properly rotated when cluster configuration changes that affect pod behavior.