fix: upgrade for cluster spec changes#2363
Open
rugggger wants to merge 1 commit into03-12-fix_unify_upgrade_path_for_image_and_configfrom
Open
fix: upgrade for cluster spec changes#2363rugggger wants to merge 1 commit into03-12-fix_unify_upgrade_path_for_image_and_configfrom
rugggger wants to merge 1 commit into03-12-fix_unify_upgrade_path_for_image_and_configfrom
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label main-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
graphite-app
bot
requested review from
assafgi,
kristina-solovyova and
tigrawap
Graphite Automations"Add anton/matt/sergey/kristina as reviwers on operator PRs" took an action on this PR • (03/16/26)3 reviewers were added to this PR based on Anton Bykov's automation. |
rugggger
force-pushed
the
03-15-fix_upgrade_for_cluster_spec_changes
branch
3 times, most recently
from
e2d50bb to
e4fa5ac
Compare
rugggger
force-pushed
the
03-15-fix_upgrade_for_cluster_spec_changes
branch
from
e4fa5ac to
c32a815
Compare
rugggger
force-pushed
the
03-15-fix_upgrade_for_cluster_spec_changes
branch
from
c32a815 to
ca23f3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Optimized cluster upgrade process to only run image-related operations when the container image actually changes, while still handling configuration-only updates.
What changed?
UpdatableFieldsstruct to track configuration changes that should trigger upgrades without requiring image operationsisImageChanged()method to distinguish between image upgrades and configuration-only updatesanyContainerConfigApplied()helper function for cleaner codeHow to test?
Why make this change?
This optimization reduces unnecessary overhead during configuration-only updates by skipping expensive image-related operations when they're not needed. Previously, any cluster specification change would trigger the full upgrade workflow including image operations, even when only configuration parameters changed.