Added handling for cloudflare ssl errors (http error 525)#115
Open
Cyberpro54321 wants to merge 2 commits into
Open
Added handling for cloudflare ssl errors (http error 525)#115Cyberpro54321 wants to merge 2 commits into
Cyberpro54321 wants to merge 2 commits into
Conversation
these not all the same function?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
works.get() will now detect a status code of 525 (signifying that there was an SSL error between Cloudflare's reverse-proxy and AO3's servers) and raise an HTTPError, instead of the previous behavior where an AttributeError would be raised when the rest of works.py tried to parse the cloudflare error page as though it were a normal work page.
Also added the HTTP error number to the text of both this exception and the existing rate-limiting exception, so that the type of error can be easily found using ordinary string parsing.