Change loading behavior for ephemeral soup#62
Draft
B-McDonnell wants to merge 1 commit into
Draft
Conversation
Collaborator
|
I noticed this pull request has been marked as a draft for ~2months, is this intended or should I test it and merge it? |
Author
|
Thanks for the ping, I forgot I had this in progress. I should have time to work on this this weekend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes loading to store all attributes instead of allowing
functools.cached_propertyto handle performance gains. This addresses #8.Because this is a major shift in the loading mechanism and slated for a major release, This also introduces a shift in what work attributes are loaded when as per #61.
Closes #8
Closes #61