Warning for Mistery Works#85
Open
encars28 wants to merge 1 commit into
Open
Conversation
When the work is being loaded it warns the user if it's a Mistery Work and stops loading the rest, so that Mistery Works no longer cause an error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would fix #81
if "Error 404" in self._soup.find("h2", {"class", "heading"}).text:The code was raising an Atribute Error because it couldn't find a h2 tag with the class "heading" (as it is a Mistery Work, its page would differ from the normal work pages). When bs4 can't find a tag, it puts that variable to None, so when we tried to acces the text attribute of a None variable an error would occur