fix mel_spectrogram cache keys to include all config parameters#120
Open
zhuxiaoxuhit wants to merge 1 commit into
Open
fix mel_spectrogram cache keys to include all config parameters#120zhuxiaoxuhit wants to merge 1 commit into
zhuxiaoxuhit wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mel_basis and hann_window caches in mel_spectrogram use incomplete keys:
Two concrete failure modes:
There's also a coupling bug: both caches were populated under a single mel_basis check, so changing fmax between calls could silently overwrite hann_window with a different win_size.
Fix: use fully qualified independent keys for each cache so different configurations don't interfere with each other.