fix: migrate dirhash to symlink aware analog#31
Merged
alexey-igrychev merged 1 commit intomainfrom Apr 14, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR replaces dirhash.HashDir usage in HashContentsAndPathsRecurse with a custom symlink-aware directory hashing helper to avoid failures when encountering directory symlinks, and adds tests validating compatibility and symlink behavior.
Changes:
- Replaced
dirhash.HashDircall with a new internalhashDirhelper that handles directory symlinks. - Implemented
hashDirto hash directory symlink targets as link-path strings (instead of attempting to read directory contents). - Added Ginkgo/Gomega tests covering file/dir hashing, compatibility with
dirhash.HashDir(no symlinks), and symlink target changes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| pkg/util/hashsum.go | Introduces hashDir and switches directory hashing to the symlink-aware implementation. |
| pkg/util/hashsum_test.go | Adds unit tests for success cases, compatibility with dirhash.HashDir, and symlink target-change behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nervgh
approved these changes
Apr 1, 2026
Signed-off-by: Radmir Khurum <radmir.khurum@flant.com>
reyreavman
force-pushed
the
fix/migrate-dirhash-to-symlink-aware-analog
branch
from
cea937b to
ca4733c
Compare
nervgh
approved these changes
Apr 7, 2026
alexey-igrychev
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.