海里数检测改为经验检测后自动检测#112
Merged
Merged
Conversation
审阅者指南（在小型 PR 上折叠显示）审阅者指南此 PR 使海里数检测在危险等级计算（hazard leveling）过程中始终自动运行，而不是再由配置开关控制，并在整个配置系统中移除已不再使用的 OpsiSeaMiles 配置及相关选项 / i18n 条目。 危险等级计算过程中海里数自动检测的时序图sequenceDiagram
participant OsHazardLeveling as os_check_leveling
participant Logger as logger
participant SeaMiles as detect_and_record_sea_miles
OsHazardLeveling->>Logger: info
Note right of Logger: 开始海里数检测
OsHazardLeveling->>SeaMiles: detect_and_record_sea_miles
SeaMiles-->>OsHazardLeveling: sea_miles
alt [sea_miles is not None]
OsHazardLeveling->>Logger: info
Note right of Logger: 海里数检测完成: {sea_miles}
else [sea_miles is None]
OsHazardLeveling->>Logger: warning
Note right of Logger: 海里数检测失败，但不影响后续流程
end
rect rgb(255,230,230)
OsHazardLeveling->>SeaMiles: [exceptions during detect_and_record_sea_miles]
OsHazardLeveling->>Logger: error
Note right of Logger: 海里数检测异常: {e}，但不影响后续流程
end
文件级变更
提示与命令与 Sourcery 交互
自定义你的体验访问你的 控制面板 可以：
获取帮助Original review guide in EnglishReviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR makes sea miles detection always run automatically during hazard leveling instead of being gated by a configuration flag, and removes the now-unused OpsiSeaMiles configuration and related options/i18n entries across the config system. Sequence diagram for automatic sea miles detection during hazard levelingsequenceDiagram
participant OsHazardLeveling as os_check_leveling
participant Logger as logger
participant SeaMiles as detect_and_record_sea_miles
OsHazardLeveling->>Logger: info
Note right of Logger: 开始海里数检测
OsHazardLeveling->>SeaMiles: detect_and_record_sea_miles
SeaMiles-->>OsHazardLeveling: sea_miles
alt [sea_miles is not None]
OsHazardLeveling->>Logger: info
Note right of Logger: 海里数检测完成: {sea_miles}
else [sea_miles is None]
OsHazardLeveling->>Logger: warning
Note right of Logger: 海里数检测失败，但不影响后续流程
end
rect rgb(255,230,230)
OsHazardLeveling->>SeaMiles: [exceptions during detect_and_record_sea_miles]
OsHazardLeveling->>Logger: error
Note right of Logger: 海里数检测异常: {e}，但不影响后续流程
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - 我在这里给出了一些整体层面的反馈：
- 由于 OpsiSeaMiles 配置组和
OpsiSeaMiles_Enable标志已被移除，请再次检查并清理对这些字段的任何剩余引用（包括通过动态属性访问的引用），以避免出现意料之外的AttributeError或遗留的死代码路径。
给 AI 代理的提示
Please address the comments from this code review:
## Overall Comments
- Since the OpsiSeaMiles config group and `OpsiSeaMiles_Enable` flag are removed, please double-check and clean up any remaining references to these fields (including dynamic attribute access) to avoid unexpected `AttributeError` or dead code paths.帮我变得更有用！请在每条评论上点 👍 或 👎，我会根据你的反馈改进后续的代码审查。
Original comment in English
Hey - I've left some high level feedback:
- Since the OpsiSeaMiles config group and
OpsiSeaMiles_Enableflag are removed, please double-check and clean up any remaining references to these fields (including dynamic attribute access) to avoid unexpectedAttributeErroror dead code paths.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since the OpsiSeaMiles config group and `OpsiSeaMiles_Enable` flag are removed, please double-check and clean up any remaining references to these fields (including dynamic attribute access) to avoid unexpected `AttributeError` or dead code paths.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the OpsiSeaMiles configuration toggle from all configuration and localization files, making the sea miles detection feature automatic. In the code, the detection logic is now executed unconditionally. The reviewer suggested improving the logging strategy by using logger.info instead of logger.warning for expected detection failures and using logger.exception to capture full stack traces during errors.
Comment on lines
+510
to
+518
| logger.info("开始海里数检测") | ||
| try: | ||
| sea_miles = self.detect_and_record_sea_miles() | ||
| if sea_miles is not None: | ||
| logger.info(f"海里数检测完成: {sea_miles}") | ||
| else: | ||
| logger.warning("海里数检测失败，但不影响后续流程") | ||
| except Exception as e: | ||
| logger.error(f"海里数检测异常: {e}，但不影响后续流程") |
Contributor
There was a problem hiding this comment.
既然海里数检测现在已改为自动执行且不影响后续流程，建议优化日志级别以减少对用户的干扰。特别是当检测失败（返回 None）时，这通常是因为不在正确的界面，使用 logger.warning 可能会让用户误以为发生了严重问题。建议将其降级为 logger.info。此外，对于异常捕获，建议使用 logger.exception 以便记录完整的堆栈信息，方便排查问题。
Suggested change
| logger.info("开始海里数检测") | |
| try: | |
| sea_miles = self.detect_and_record_sea_miles() | |
| if sea_miles is not None: | |
| logger.info(f"海里数检测完成: {sea_miles}") | |
| else: | |
| logger.warning("海里数检测失败，但不影响后续流程") | |
| except Exception as e: | |
| logger.error(f"海里数检测异常: {e}，但不影响后续流程") | |
| logger.info("开始海里数检测") | |
| try: | |
| sea_miles = self.detect_and_record_sea_miles() | |
| if sea_miles is not None: | |
| logger.info(f"海里数检测完成: {sea_miles}") | |
| else: | |
| logger.info("海里数检测失败，但不影响后续流程") | |
| except Exception: | |
| logger.exception("海里数检测异常，但不影响后续流程") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
在危险等级评估过程中始终执行海里检测，并移除已过时的配置开关。
Enhancements:
Chores:
Original summary in English
Summary by Sourcery
Always perform sea miles detection during hazard leveling and remove the now-obsolete configuration toggle.
Enhancements:
Chores: