Fix BFGS reset logic in relaxation.py#9
Open
LorenzoGottardi1210 wants to merge 1 commit into
Open
Conversation
Fixed a bug where self.inv_hess was being overwritten with None during a BFGS reset. The previous implementation called self.inv_hess = self._reset_bfgs(), but since the method lacked a return statement, it assigned None to the Hessian matrix. This caused a TypeError in the subsequent np.dot calculation. Updated the call to self._reset_bfgs() as a standalone method, which correctly updates the internal state without nullifying the variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug where self.inv_hess was being overwritten with None during a BFGS reset.
The previous implementation called self.inv_hess = self._reset_bfgs(), but since the method lacked a return statement, it assigned None to the Hessian matrix. This caused a TypeError in the subsequent np.dot calculation.
Updated the call to self._reset_bfgs() as a standalone method, which correctly updates the internal state without nullifying the variable.