enh: Make laravel.mk extensible and add multi-arch builds#1
Merged
Conversation
Code Review SummaryThis PR enhances the Laravel Makefile to be more extensible for downstream projects and adds a robust multi-arch (AMD64/ARM64) build pipeline using GitHub Actions native ARM runners. 🚀 Key Improvements
💡 Minor Suggestions
|
nfebe
force-pushed
the
enhance/extensible-makefile-multiarch
branch
from
1193b4c to
97e3de8
Compare
![sourceant[bot]](https://avatars.githubusercontent.com/in/1161781?s=60&v=4){kind=small}
Added hook variables (EXTRA_PORTS_SCRIPT, EXTRA_UP_INFO, TEST_CMD, LINT_CMD) so projects can customize behavior via include without overriding targets. Fixed DC variable to strip comments from .ports file and help target to deduplicate entries across multiple Makefiles. Added QEMU and linux/amd64,linux/arm64 platforms to the publish workflow so images work on Apple Silicon.
nfebe
force-pushed
the
enhance/extensible-makefile-multiarch
branch
from
97e3de8 to
4067a6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added hook variables (EXTRA_PORTS_SCRIPT, EXTRA_UP_INFO, TEST_CMD, LINT_CMD) so projects can customize behavior via include without overriding targets. Fixed DC variable to strip comments from .ports file and help target to deduplicate entries across multiple Makefiles.
Added QEMU and linux/amd64,linux/arm64 platforms to the publish workflow so images work on Apple Silicon.