enh: Add dev tools and fix permissions#3
Merged
Conversation
- Add essential dev tools: sudo, vim, nano, wget, htop, jq, etc - Add network debugging tools: netcat, telnet, ping - Add build tools: build-essential, rsync - Configure GD with full support: freetype, jpeg, webp - Fix /var/www ownership for www-data user - Pre-create .composer cache directory with correct permissions - Configure git safe.directory to allow any directory Fixes permission issues where www-data couldn't write to /var/www for Composer cache and git config. Signed-off-by: nfebe <fenn25.fn@gmail.com>
Code Review SummaryThe PR adds a comprehensive suite of development and debugging tools to the Docker environment and addresses common permission issues with Composer and Git. 🚀 Key Improvements
💡 Minor Suggestions
|
![sourceant[bot]](https://avatars.githubusercontent.com/in/1161781?s=60&v=4){kind=small}
| nginx \ | ||
| git \ | ||
| curl \ | ||
| sudo \ |
There was a problem hiding this comment.
Adding debugging and build tools (sudo, vim, build-essential, etc.) significantly increases the image size and security risk. Consider moving these to a multi-stage build or a separate 'dev' target if this image is intended for production.
Suggested change
| sudo \ | |
| + # Consider moving dev tools to a separate build stage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes permission issues where www-data couldn't write to /var/www for Composer cache and git config.